2022-03-09 07:13:06

by Kunihiko Hayashi

[permalink] [raw]
Subject: [PATCH] clk: uniphier: Fix fixed-rate initialization

Fixed-rate clocks in UniPhier don't have any parent clocks, however,
initial data "init.flags" isn't initialized, so it might be determined
that there is a parent clock for fixed-rate clock.

This sets init.flags to zero as initialization.

Cc: <[email protected]>
Fixes: 734d82f4a678 ("clk: uniphier: add core support code for UniPhier clock driver")
Signed-off-by: Kunihiko Hayashi <[email protected]>
---
drivers/clk/uniphier/clk-uniphier-fixed-rate.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/clk/uniphier/clk-uniphier-fixed-rate.c b/drivers/clk/uniphier/clk-uniphier-fixed-rate.c
index 5319cd380480..3bc55ab75314 100644
--- a/drivers/clk/uniphier/clk-uniphier-fixed-rate.c
+++ b/drivers/clk/uniphier/clk-uniphier-fixed-rate.c
@@ -24,6 +24,7 @@ struct clk_hw *uniphier_clk_register_fixed_rate(struct device *dev,

init.name = name;
init.ops = &clk_fixed_rate_ops;
+ init.flags = 0;
init.parent_names = NULL;
init.num_parents = 0;

--
2.7.4


2022-03-12 06:36:32

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH] clk: uniphier: Fix fixed-rate initialization

Quoting Kunihiko Hayashi (2022-03-08 22:55:18)
> Fixed-rate clocks in UniPhier don't have any parent clocks, however,
> initial data "init.flags" isn't initialized, so it might be determined
> that there is a parent clock for fixed-rate clock.
>
> This sets init.flags to zero as initialization.
>
> Cc: <[email protected]>
> Fixes: 734d82f4a678 ("clk: uniphier: add core support code for UniPhier clock driver")
> Signed-off-by: Kunihiko Hayashi <[email protected]>
> ---

Applied to clk-next