On Sat, 12 Mar 2022 17:27:44 +0100
Alexander Vorwerk <[email protected]> wrote:
> reported by checkpatch.pl
>
> Signed-off-by: Alexander Vorwerk <[email protected]>
> ---
> net/ipv4/tcp.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
> index 28ff2a820f7c..7fa6e7e6ea80 100644
> --- a/net/ipv4/tcp.c
> +++ b/net/ipv4/tcp.c
> @@ -959,10 +959,10 @@ static struct sk_buff *tcp_build_frag(struct sock *sk, int size_goal, int flags,
> struct sk_buff *skb = tcp_write_queue_tail(sk);
> struct tcp_sock *tp = tcp_sk(sk);
> bool can_coalesce;
> - int copy, i;
> + int copy = size_goal - skb->len;
> + int i;
>
> - if (!skb || (copy = size_goal - skb->len) <= 0 ||
> - !tcp_skb_can_collapse_to(skb)) {
> + if (!skb || copy <= 0 || !tcp_skb_can_collapse_to(skb)) {
> new_segment:
> if (!sk_stream_memory_free(sk))
> return NULL;
Your new code will crash if skb is NULL.