For the AF configuration, if the rightmost stripe is used, the AF scene
will be at the incorrect location of the sensor.
The AF coordinate may be set to the right part of the sensor. This
configuration would lead to x_start being greater than the
down_scaled_stripes offset and the leftmost stripe would be disabled
and only the rightmost stripe is used to control the AF coordinate. If
the x_start doesn't perform any adjustments, the AF coordinate will be
at the wrong place of the sensor since down_scaled_stripes offset
would be the new zero of the coordinate system.
In this patch, if only the rightmost stripe is used, x_start should
minus down_scaled_stripes offset to maintain its correctness of AF
scene coordinate.
Changes in v2:
1. Remove the setting of the first stripe.
Signed-off-by: Kate Hsuan <[email protected]>
---
drivers/staging/media/ipu3/ipu3-css-params.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/media/ipu3/ipu3-css-params.c b/drivers/staging/media/ipu3/ipu3-css-params.c
index d9e3c3785075..5a8c07f34756 100644
--- a/drivers/staging/media/ipu3/ipu3-css-params.c
+++ b/drivers/staging/media/ipu3/ipu3-css-params.c
@@ -2556,6 +2556,10 @@ int imgu_css_cfg_acc(struct imgu_css *css, unsigned int pipe,
/* Enable only for rightmost stripe, disable left */
acc->af.stripes[0].grid_cfg.y_start &=
~IPU3_UAPI_GRID_Y_START_EN;
+ acc->af.stripes[1].grid_cfg.x_start -=
+ acc->stripe.down_scaled_stripes[1].offset;
+ acc->af.stripes[1].grid_cfg.x_end -=
+ acc->stripe.down_scaled_stripes[1].offset;
} else if (acc->af.config.grid_cfg.x_end <=
acc->stripe.bds_out_stripes[0].width - min_overlap) {
/* Enable only for leftmost stripe, disable right */
--
2.35.1
If both stripes are enabled, an improper AF grid configuration leads
the AF scene width to be wilder than the BDS width. Also, the second
stripe x_end is estimated based on the remaining AF scene width.
Therefore, the second stripe x_end will be greater than the second
stripe BDS width.
In this patch, if the second stripe x_end is greater than BDS width,
x_end will be set to BDS width.
Signed-off-by: Kate Hsuan <[email protected]>
---
drivers/staging/media/ipu3/ipu3-css-params.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/media/ipu3/ipu3-css-params.c b/drivers/staging/media/ipu3/ipu3-css-params.c
index 5a8c07f34756..8923760aa913 100644
--- a/drivers/staging/media/ipu3/ipu3-css-params.c
+++ b/drivers/staging/media/ipu3/ipu3-css-params.c
@@ -2593,6 +2593,10 @@ int imgu_css_cfg_acc(struct imgu_css *css, unsigned int pipe,
acc->af.stripes[1].grid_cfg.width,
b_w_log2);
+ if (acc->af.stripes[1].grid_cfg.x_end >= acc->stripe.bds_out_stripes[1].width)
+ acc->af.stripes[1].grid_cfg.x_end =
+ acc->stripe.bds_out_stripes[1].width - min_overlap;
+
/*
* To reduce complexity of debubbling and loading statistics
* fix grid_height_per_slice to 1 for both stripes
--
2.35.1
Hi Kate,
On Mon, Mar 14, 2022 at 06:15:22PM +0800, Kate Hsuan wrote:
> For the AF configuration, if the rightmost stripe is used, the AF scene
> will be at the incorrect location of the sensor.
>
> The AF coordinate may be set to the right part of the sensor. This
> configuration would lead to x_start being greater than the
> down_scaled_stripes offset and the leftmost stripe would be disabled
> and only the rightmost stripe is used to control the AF coordinate. If
> the x_start doesn't perform any adjustments, the AF coordinate will be
> at the wrong place of the sensor since down_scaled_stripes offset
> would be the new zero of the coordinate system.
>
> In this patch, if only the rightmost stripe is used, x_start should
> minus down_scaled_stripes offset to maintain its correctness of AF
> scene coordinate.
>
> Changes in v2:
> 1. Remove the setting of the first stripe.
>
> Signed-off-by: Kate Hsuan <[email protected]>
> ---
> drivers/staging/media/ipu3/ipu3-css-params.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/staging/media/ipu3/ipu3-css-params.c b/drivers/staging/media/ipu3/ipu3-css-params.c
> index d9e3c3785075..5a8c07f34756 100644
> --- a/drivers/staging/media/ipu3/ipu3-css-params.c
> +++ b/drivers/staging/media/ipu3/ipu3-css-params.c
> @@ -2556,6 +2556,10 @@ int imgu_css_cfg_acc(struct imgu_css *css, unsigned int pipe,
> /* Enable only for rightmost stripe, disable left */
> acc->af.stripes[0].grid_cfg.y_start &=
> ~IPU3_UAPI_GRID_Y_START_EN;
> + acc->af.stripes[1].grid_cfg.x_start -=
> + acc->stripe.down_scaled_stripes[1].offset;
> + acc->af.stripes[1].grid_cfg.x_end -=
> + acc->stripe.down_scaled_stripes[1].offset;
Could you calculate the values the same way as for the two stripes case, as
I've been asking since v1?
> } else if (acc->af.config.grid_cfg.x_end <=
> acc->stripe.bds_out_stripes[0].width - min_overlap) {
> /* Enable only for leftmost stripe, disable right */
--
Regards,
Sakari Ailus
Hi Sakari,
On Wed, Mar 16, 2022 at 5:02 PM Sakari Ailus
<[email protected]> wrote:
>
> Hi Kate,
>
> On Mon, Mar 14, 2022 at 06:15:22PM +0800, Kate Hsuan wrote:
> > For the AF configuration, if the rightmost stripe is used, the AF scene
> > will be at the incorrect location of the sensor.
> >
> > The AF coordinate may be set to the right part of the sensor. This
> > configuration would lead to x_start being greater than the
> > down_scaled_stripes offset and the leftmost stripe would be disabled
> > and only the rightmost stripe is used to control the AF coordinate. If
> > the x_start doesn't perform any adjustments, the AF coordinate will be
> > at the wrong place of the sensor since down_scaled_stripes offset
> > would be the new zero of the coordinate system.
> >
> > In this patch, if only the rightmost stripe is used, x_start should
> > minus down_scaled_stripes offset to maintain its correctness of AF
> > scene coordinate.
> >
> > Changes in v2:
> > 1. Remove the setting of the first stripe.
> >
> > Signed-off-by: Kate Hsuan <[email protected]>
> > ---
> > drivers/staging/media/ipu3/ipu3-css-params.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/staging/media/ipu3/ipu3-css-params.c b/drivers/staging/media/ipu3/ipu3-css-params.c
> > index d9e3c3785075..5a8c07f34756 100644
> > --- a/drivers/staging/media/ipu3/ipu3-css-params.c
> > +++ b/drivers/staging/media/ipu3/ipu3-css-params.c
> > @@ -2556,6 +2556,10 @@ int imgu_css_cfg_acc(struct imgu_css *css, unsigned int pipe,
> > /* Enable only for rightmost stripe, disable left */
> > acc->af.stripes[0].grid_cfg.y_start &=
> > ~IPU3_UAPI_GRID_Y_START_EN;
> > + acc->af.stripes[1].grid_cfg.x_start -=
> > + acc->stripe.down_scaled_stripes[1].offset;
> > + acc->af.stripes[1].grid_cfg.x_end -=
> > + acc->stripe.down_scaled_stripes[1].offset;
>
> Could you calculate the values the same way as for the two stripes case, as
> I've been asking since v1?
Sorry for my misunderstanding of the comments.
You mean x_end could be estimated by the width here and could use the
same way as for two stripes case to estimate this.
I'll correct this in my v4 patch. :)
Thank you.
>
> > } else if (acc->af.config.grid_cfg.x_end <=
> > acc->stripe.bds_out_stripes[0].width - min_overlap) {
> > /* Enable only for leftmost stripe, disable right */
>
> --
> Regards,
>
> Sakari Ailus
>
--
BR,
Kate