On 22/03/14 04:02PM, Ojaswin Mujoo wrote:
> Add support to test the mb_optimize_scan mount option.
> Since its value is not reflected in the "options" file in proc,
> use "mb_structs_summary" to verify its value.
Yes, I think we can do this. Thanks for identifying it.
>
> Signed-off-by: Ojaswin Mujoo <[email protected]>
Overall the patch looks good to me. Feel free to add
Reviewed-by: Ritesh Harjani <[email protected]>
> ---
> tests/ext4/053 | 21 ++++++++++++---------
> 1 file changed, 12 insertions(+), 9 deletions(-)
<Some stats>
I ran this test of yours with and w/o your kernel fix for this mount option,
which is now sitting in ext4 dev tree [1].
<with kernel fix>
ext4/053 173s ... 147s
Ran: ext4/053
Passed all 1 tests
<w/o kernel fix>
ext4/053 173s ... [failed, exit status 2]- output mismatch (see /home/qemu/work/tools/xfstests-dev/results//ext4_4k/ext4/053.out.bad)
--- tests/ext4/053.out 2022-01-03 11:50:08.671463501 +0530
+++ /home/qemu/work/tools/xfstests-dev/results//ext4_4k/ext4/053.out.bad 2022-03-14 18:26:12.290610687 +0530
@@ -1,2 +1,4 @@
QA output created by 053
Silence is golden.
+mounting ext3 "mb_optimize_scan=1" checking "mb_optimize_scan=1" (not found) FAILED
+mounting ext4 "mb_optimize_scan=1" checking "mb_optimize_scan=1" (not found) FAILED
...
(Run 'diff -u /home/qemu/work/tools/xfstests-dev/tests/ext4/053.out /home/qemu/work/tools/xfstests-dev/results//ext4_4k/ext4/053.out.bad' to see the entire diff)
Ran: ext4/053
Failures: ext4/053
Failed 1 of 1 tests
[1]: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git/commit/?h=dev&id=27b38686a3bb601db48901dbc4e2fc5d77ffa2c1