2022-03-15 17:06:16

by Krzysztof Kozlowski

Subject: [PATCH 1/5] ARM: dts: exynos: align EHCI/OHCI nodes with dtschema on Exynos4

The node names should be generic and USB DT schema expects "usb" names.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm/boot/dts/exynos4.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index e81b3ee4e0f7..5fd17bc52321 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -373,7 +373,7 @@ hsotg: hsotg@12480000 {
status = "disabled";
};

- ehci: ehci@12580000 {
+ ehci: usb@12580000 {
compatible = "samsung,exynos4210-ehci";
reg = <0x12580000 0x100>;
interrupts = <GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH>;
@@ -384,7 +384,7 @@ ehci: ehci@12580000 {
phy-names = "host", "hsic0", "hsic1";
};

- ohci: ohci@12590000 {
+ ohci: usb@12590000 {
compatible = "samsung,exynos4210-ohci";
reg = <0x12590000 0x100>;
interrupts = <GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH>;
--
2.32.0

2022-03-16 21:07:45

by Alim Akhtar

Subject: RE: [PATCH 1/5] ARM: dts: exynos: align EHCI/OHCI nodes with dtschema on Exynos4

>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:[email protected]]
>Sent: Monday, March 14, 2022 11:50 PM
>To: Greg Kroah-Hartman <[email protected]>; Rob Herring
><[email protected]>; Krzysztof Kozlowski <[email protected]>; Alim
>Akhtar <[email protected]>; [email protected];
>[email protected]; [email protected]; linux-
>[email protected]; [email protected]
>Cc: Krzysztof Kozlowski <[email protected]>
>Subject: [PATCH 1/5] ARM: dts: exynos: align EHCI/OHCI nodes with dtschema
>on Exynos4
>
>The node names should be generic and USB DT schema expects "usb" names.
>
>Signed-off-by: Krzysztof Kozlowski <[email protected]>
>---

Reviewed-by: Alim Akhtar <[email protected]>


> arch/arm/boot/dts/exynos4.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/arch/arm/boot/dts/exynos4.dtsi
>b/arch/arm/boot/dts/exynos4.dtsi index e81b3ee4e0f7..5fd17bc52321 100644
>--- a/arch/arm/boot/dts/exynos4.dtsi
>+++ b/arch/arm/boot/dts/exynos4.dtsi
>@@ -373,7 +373,7 @@ hsotg: hsotg@12480000 {
> status = "disabled";
> };
>
>- ehci: ehci@12580000 {
>+ ehci: usb@12580000 {
> compatible = "samsung,exynos4210-ehci";
> reg = <0x12580000 0x100>;
> interrupts = <GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH>;
>@@ -384,7 +384,7 @@ ehci: ehci@12580000 {
> phy-names = "host", "hsic0", "hsic1";
> };
>
>- ohci: ohci@12590000 {
>+ ohci: usb@12590000 {
> compatible = "samsung,exynos4210-ohci";
> reg = <0x12590000 0x100>;
> interrupts = <GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH>;
>--
>2.32.0

2022-03-17 05:27:49

by Krzysztof Kozlowski

Subject: [PATCH 4/5] dt-bindings: usb: samsung,exynos-usb2: add missing required reg

"reg" property is required on Samsung S5PV210/Exynos EHCI/OHCI
controllers.

Fixes: 4bf2283cb208 ("dt-bindings: usb: samsung,exynos-usb2: convert to dtschema")
Signed-off-by: Krzysztof Kozlowski <[email protected]>

---

Fixed commit in current next. If this should go as fix, I can split it
from the second commit.
---
Documentation/devicetree/bindings/usb/samsung,exynos-usb2.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/usb/samsung,exynos-usb2.yaml b/Documentation/devicetree/bindings/usb/samsung,exynos-usb2.yaml
index fbf07d6e707a..ef42c6fce73c 100644
--- a/Documentation/devicetree/bindings/usb/samsung,exynos-usb2.yaml
+++ b/Documentation/devicetree/bindings/usb/samsung,exynos-usb2.yaml
@@ -62,6 +62,7 @@ required:
- interrupts
- phys
- phy-names
+ - reg

allOf:
- if:
--
2.32.0

2022-03-21 23:01:01

by Rob Herring (Arm)

Subject: Re: [PATCH 4/5] dt-bindings: usb: samsung,exynos-usb2: add missing required reg

On Mon, 14 Mar 2022 19:19:47 +0100, Krzysztof Kozlowski wrote:
> "reg" property is required on Samsung S5PV210/Exynos EHCI/OHCI
> controllers.
>
> Fixes: 4bf2283cb208 ("dt-bindings: usb: samsung,exynos-usb2: convert to dtschema")
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
>
> Fixed commit in current next. If this should go as fix, I can split it
> from the second commit.
> ---
> Documentation/devicetree/bindings/usb/samsung,exynos-usb2.yaml | 1 +
> 1 file changed, 1 insertion(+)
>

Acked-by: Rob Herring <[email protected]>

2022-04-05 02:06:36

by Krzysztof Kozlowski

Subject: Re: (subset) [PATCH 1/5] ARM: dts: exynos: align EHCI/OHCI nodes with dtschema on Exynos4

On Mon, 14 Mar 2022 19:19:44 +0100, Krzysztof Kozlowski wrote:
> The node names should be generic and USB DT schema expects "usb" names.
>
>

Applied, thanks!

[1/5] ARM: dts: exynos: align EHCI/OHCI nodes with dtschema on Exynos4
commit: b412be7d3c0a248db0de4b7b53ee6ad44d49c71b

Best regards,
--
Krzysztof Kozlowski <[email protected]>