2022-03-11 16:47:56

by Kuldeep Singh

Subject: [PATCH] ARM: dts: bcm-cygnus: Update spi clock properties

PL022 binding require two clocks to be defined but broadcom cygnus
platform doesn't comply with bindings and define only one clock.

Update spi clocks and clocks-names property by adding appropriate clock
reference to make it compliant with bindings.

CC: Florian Fainelli <[email protected]>
Signed-off-by: Kuldeep Singh <[email protected]>
---
arch/arm/boot/dts/bcm-cygnus.dtsi | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi
index ad65be871938..f9f79ed82518 100644
--- a/arch/arm/boot/dts/bcm-cygnus.dtsi
+++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
@@ -397,8 +397,8 @@ spi0: spi@18028000 {
#size-cells = <0>;
interrupts = <GIC_SPI 78 IRQ_TYPE_LEVEL_HIGH>;
pinctrl-0 = <&spi_0>;
- clocks = <&axi81_clk>;
- clock-names = "apb_pclk";
+ clocks = <&axi81_clk>, <&axi81_clk>;
+ clock-names = "sspclk", "apb_pclk";
status = "disabled";
};

@@ -409,8 +409,8 @@ spi1: spi@18029000 {
#size-cells = <0>;
interrupts = <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>;
pinctrl-0 = <&spi_1>;
- clocks = <&axi81_clk>;
- clock-names = "apb_pclk";
+ clocks = <&axi81_clk>, <&axi81_clk>;
+ clock-names = "sspclk", "apb_pclk";
status = "disabled";
};

@@ -421,8 +421,8 @@ spi2: spi@1802a000 {
#size-cells = <0>;
interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>;
pinctrl-0 = <&spi_2>;
- clocks = <&axi81_clk>;
- clock-names = "apb_pclk";
+ clocks = <&axi81_clk>, <&axi81_clk>;
+ clock-names = "sspclk", "apb_pclk";
status = "disabled";
};

--
2.25.1

2022-03-17 05:19:52

by Kuldeep Singh

Subject: Re: [PATCH] ARM: dts: bcm-cygnus: Update spi clock properties

On Fri, Mar 11, 2022 at 02:11:14PM +0530, Kuldeep Singh wrote:
> PL022 binding require two clocks to be defined but broadcom cygnus
> platform doesn't comply with bindings and define only one clock.
>
> Update spi clocks and clocks-names property by adding appropriate clock
> reference to make it compliant with bindings.
>
> CC: Florian Fainelli <[email protected]>
> Signed-off-by: Kuldeep Singh <[email protected]>

Florian, this patch was initially based on stblinux,devicetree-arm64. I
just checked on devicetree branch, and it can apply cleanly anyway. I
hope there shouldn't be any need to send patch again. Please let me know
in case something needs to be taken care. Thanks!

-Kuldeep

2022-04-04 23:38:19

by Florian Fainelli

Subject: Re: [PATCH] ARM: dts: bcm-cygnus: Update spi clock properties

On Fri, 11 Mar 2022 14:11:14 +0530, Kuldeep Singh <[email protected]> wrote:
> PL022 binding require two clocks to be defined but broadcom cygnus
> platform doesn't comply with bindings and define only one clock.
>
> Update spi clocks and clocks-names property by adding appropriate clock
> reference to make it compliant with bindings.
>
> CC: Florian Fainelli <[email protected]>
> Signed-off-by: Kuldeep Singh <[email protected]>
> ---

Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks!
--
Florian