2022-03-17 05:00:02

by Xiaomeng Tong

[permalink] [raw]
Subject: [PATCH] usb: gadget: udc-xilinx: remove unnecessary initialization of list iterator

'req' will always be set by the subsequent list_for_each_entry()
before any uses. Thus, to avoid ambiguity it is better to remove
the unnecessary initialization of list iterator 'req'.

Signed-off-by: Xiaomeng Tong <[email protected]>
---
drivers/usb/gadget/udc/udc-xilinx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/udc-xilinx.c b/drivers/usb/gadget/udc/udc-xilinx.c
index 6ce886fb7..fa6cbfc63 100644
--- a/drivers/usb/gadget/udc/udc-xilinx.c
+++ b/drivers/usb/gadget/udc/udc-xilinx.c
@@ -1136,7 +1136,7 @@ static int xudc_ep_queue(struct usb_ep *_ep, struct usb_request *_req,
static int xudc_ep_dequeue(struct usb_ep *_ep, struct usb_request *_req)
{
struct xusb_ep *ep = to_xusb_ep(_ep);
- struct xusb_req *req = to_xusb_req(_req);
+ struct xusb_req *req;
struct xusb_udc *udc = ep->udc;
unsigned long flags;

--
2.17.1


2022-04-22 18:31:27

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] usb: gadget: udc-xilinx: remove unnecessary initialization of list iterator

On Wed, Mar 16, 2022 at 03:51:53PM +0800, Xiaomeng Tong wrote:
> 'req' will always be set by the subsequent list_for_each_entry()
> before any uses. Thus, to avoid ambiguity it is better to remove
> the unnecessary initialization of list iterator 'req'.
>
> Signed-off-by: Xiaomeng Tong <[email protected]>
> ---
> drivers/usb/gadget/udc/udc-xilinx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/udc/udc-xilinx.c b/drivers/usb/gadget/udc/udc-xilinx.c
> index 6ce886fb7..fa6cbfc63 100644
> --- a/drivers/usb/gadget/udc/udc-xilinx.c
> +++ b/drivers/usb/gadget/udc/udc-xilinx.c
> @@ -1136,7 +1136,7 @@ static int xudc_ep_queue(struct usb_ep *_ep, struct usb_request *_req,
> static int xudc_ep_dequeue(struct usb_ep *_ep, struct usb_request *_req)
> {
> struct xusb_ep *ep = to_xusb_ep(_ep);
> - struct xusb_req *req = to_xusb_req(_req);
> + struct xusb_req *req;
> struct xusb_udc *udc = ep->udc;
> unsigned long flags;
>
> --
> 2.17.1
>

Does not apply anymore :(