2022-03-16 14:25:43

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 2/2] dt-bindings: clock: drop useless consumer example

Consumer examples in the bindings of resource providers are trivial,
useless and duplication of code. Remove the example code for consumer

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/clock/bitmain,bm1880-clk.yaml | 12 ------------
.../devicetree/bindings/clock/idt,versaclock5.yaml | 7 -------
.../devicetree/bindings/clock/imx1-clock.yaml | 9 ---------
.../devicetree/bindings/clock/imx21-clock.yaml | 9 ---------
.../devicetree/bindings/clock/imx23-clock.yaml | 9 ---------
.../devicetree/bindings/clock/imx25-clock.yaml | 8 --------
.../devicetree/bindings/clock/imx27-clock.yaml | 9 ---------
.../devicetree/bindings/clock/imx28-clock.yaml | 9 ---------
.../devicetree/bindings/clock/imx31-clock.yaml | 8 --------
.../devicetree/bindings/clock/imx35-clock.yaml | 8 --------
.../devicetree/bindings/clock/imx7ulp-pcc-clock.yaml | 11 -----------
.../devicetree/bindings/clock/imx7ulp-scg-clock.yaml | 11 -----------
.../devicetree/bindings/clock/imx8qxp-lpcg.yaml | 11 -----------
.../devicetree/bindings/clock/imxrt1050-clock.yaml | 8 --------
.../bindings/clock/nvidia,tegra124-car.yaml | 7 -------
.../bindings/clock/nvidia,tegra20-car.yaml | 7 -------
16 files changed, 143 deletions(-)

diff --git a/Documentation/devicetree/bindings/clock/bitmain,bm1880-clk.yaml b/Documentation/devicetree/bindings/clock/bitmain,bm1880-clk.yaml
index 228c9313df53..f0f9392470a6 100644
--- a/Documentation/devicetree/bindings/clock/bitmain,bm1880-clk.yaml
+++ b/Documentation/devicetree/bindings/clock/bitmain,bm1880-clk.yaml
@@ -61,16 +61,4 @@ examples:
#clock-cells = <1>;
};

- # Example UART controller node that consumes clock generated by the clock controller:
- - |
- uart0: serial@58018000 {
- compatible = "snps,dw-apb-uart";
- reg = <0x58018000 0x2000>;
- clocks = <&clk 45>, <&clk 46>;
- clock-names = "baudclk", "apb_pclk";
- interrupts = <0 9 4>;
- reg-shift = <2>;
- reg-io-width = <4>;
- };
-
...
diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
index ffd6ae0eed64..be66f1e8b547 100644
--- a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
+++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
@@ -191,11 +191,4 @@ examples:
};
};

- /* Consumer referencing the 5P49V5923 pin OUT1 */
- consumer {
- /* ... */
- clocks = <&vc5 1>;
- /* ... */
- };
-
...
diff --git a/Documentation/devicetree/bindings/clock/imx1-clock.yaml b/Documentation/devicetree/bindings/clock/imx1-clock.yaml
index f4833a29b79e..56f524780b1a 100644
--- a/Documentation/devicetree/bindings/clock/imx1-clock.yaml
+++ b/Documentation/devicetree/bindings/clock/imx1-clock.yaml
@@ -40,12 +40,3 @@ examples:
compatible = "fsl,imx1-ccm";
reg = <0x0021b000 0x1000>;
};
-
- pwm@208000 {
- #pwm-cells = <2>;
- compatible = "fsl,imx1-pwm";
- reg = <0x00208000 0x1000>;
- interrupts = <34>;
- clocks = <&clks IMX1_CLK_DUMMY>, <&clks IMX1_CLK_PER1>;
- clock-names = "ipg", "per";
- };
diff --git a/Documentation/devicetree/bindings/clock/imx21-clock.yaml b/Documentation/devicetree/bindings/clock/imx21-clock.yaml
index 518ad9a4733c..e2d50544700a 100644
--- a/Documentation/devicetree/bindings/clock/imx21-clock.yaml
+++ b/Documentation/devicetree/bindings/clock/imx21-clock.yaml
@@ -40,12 +40,3 @@ examples:
reg = <0x10027000 0x800>;
#clock-cells = <1>;
};
-
- serial@1000a000 {
- compatible = "fsl,imx21-uart";
- reg = <0x1000a000 0x1000>;
- interrupts = <20>;
- clocks = <&clks IMX21_CLK_UART1_IPG_GATE>,
- <&clks IMX21_CLK_PER1>;
- clock-names = "ipg", "per";
- };
diff --git a/Documentation/devicetree/bindings/clock/imx23-clock.yaml b/Documentation/devicetree/bindings/clock/imx23-clock.yaml
index 5e296a00e14f..7e890ab9c77d 100644
--- a/Documentation/devicetree/bindings/clock/imx23-clock.yaml
+++ b/Documentation/devicetree/bindings/clock/imx23-clock.yaml
@@ -83,12 +83,3 @@ examples:
reg = <0x80040000 0x2000>;
#clock-cells = <1>;
};
-
- serial@8006c000 {
- compatible = "fsl,imx23-auart";
- reg = <0x8006c000 0x2000>;
- interrupts = <24>;
- clocks = <&clks 32>;
- dmas = <&dma_apbx 6>, <&dma_apbx 7>;
- dma-names = "rx", "tx";
- };
diff --git a/Documentation/devicetree/bindings/clock/imx25-clock.yaml b/Documentation/devicetree/bindings/clock/imx25-clock.yaml
index 2a2b10778e72..1792e138984b 100644
--- a/Documentation/devicetree/bindings/clock/imx25-clock.yaml
+++ b/Documentation/devicetree/bindings/clock/imx25-clock.yaml
@@ -176,11 +176,3 @@ examples:
interrupts = <31>;
#clock-cells = <1>;
};
-
- serial@43f90000 {
- compatible = "fsl,imx25-uart", "fsl,imx21-uart";
- reg = <0x43f90000 0x4000>;
- interrupts = <45>;
- clocks = <&clks 79>, <&clks 50>;
- clock-names = "ipg", "per";
- };
diff --git a/Documentation/devicetree/bindings/clock/imx27-clock.yaml b/Documentation/devicetree/bindings/clock/imx27-clock.yaml
index 160268f24487..99925aa22a4c 100644
--- a/Documentation/devicetree/bindings/clock/imx27-clock.yaml
+++ b/Documentation/devicetree/bindings/clock/imx27-clock.yaml
@@ -44,12 +44,3 @@ examples:
interrupts = <31>;
#clock-cells = <1>;
};
-
- serial@1000a000 {
- compatible = "fsl,imx27-uart", "fsl,imx21-uart";
- reg = <0x1000a000 0x1000>;
- interrupts = <20>;
- clocks = <&clks IMX27_CLK_UART1_IPG_GATE>,
- <&clks IMX27_CLK_PER1_GATE>;
- clock-names = "ipg", "per";
- };
diff --git a/Documentation/devicetree/bindings/clock/imx28-clock.yaml b/Documentation/devicetree/bindings/clock/imx28-clock.yaml
index f831b780f951..a542d680b1ca 100644
--- a/Documentation/devicetree/bindings/clock/imx28-clock.yaml
+++ b/Documentation/devicetree/bindings/clock/imx28-clock.yaml
@@ -106,12 +106,3 @@ examples:
reg = <0x80040000 0x2000>;
#clock-cells = <1>;
};
-
- serial@8006a000 {
- compatible = "fsl,imx28-auart";
- reg = <0x8006a000 0x2000>;
- interrupts = <112>;
- dmas = <&dma_apbx 8>, <&dma_apbx 9>;
- dma-names = "rx", "tx";
- clocks = <&clks 45>;
- };
diff --git a/Documentation/devicetree/bindings/clock/imx31-clock.yaml b/Documentation/devicetree/bindings/clock/imx31-clock.yaml
index d2336261c922..168c8ada5e81 100644
--- a/Documentation/devicetree/bindings/clock/imx31-clock.yaml
+++ b/Documentation/devicetree/bindings/clock/imx31-clock.yaml
@@ -110,11 +110,3 @@ examples:
interrupts = <31>, <53>;
#clock-cells = <1>;
};
-
- serial@43f90000 {
- compatible = "fsl,imx31-uart", "fsl,imx21-uart";
- reg = <0x43f90000 0x4000>;
- interrupts = <45>;
- clocks = <&clks 10>, <&clks 30>;
- clock-names = "ipg", "per";
- };
diff --git a/Documentation/devicetree/bindings/clock/imx35-clock.yaml b/Documentation/devicetree/bindings/clock/imx35-clock.yaml
index 3e20ccaf8131..6415bb6a8d04 100644
--- a/Documentation/devicetree/bindings/clock/imx35-clock.yaml
+++ b/Documentation/devicetree/bindings/clock/imx35-clock.yaml
@@ -129,11 +129,3 @@ examples:
interrupts = <31>;
#clock-cells = <1>;
};
-
- mmc@53fb4000 {
- compatible = "fsl,imx35-esdhc";
- reg = <0x53fb4000 0x4000>;
- interrupts = <7>;
- clocks = <&clks 9>, <&clks 8>, <&clks 43>;
- clock-names = "ipg", "ahb", "per";
- };
diff --git a/Documentation/devicetree/bindings/clock/imx7ulp-pcc-clock.yaml b/Documentation/devicetree/bindings/clock/imx7ulp-pcc-clock.yaml
index 7caf5cee9199..739c3378f8c8 100644
--- a/Documentation/devicetree/bindings/clock/imx7ulp-pcc-clock.yaml
+++ b/Documentation/devicetree/bindings/clock/imx7ulp-pcc-clock.yaml
@@ -108,14 +108,3 @@ examples:
"upll", "sosc_bus_clk", "firc_bus_clk",
"rosc", "spll_bus_clk";
};
-
- mmc@40380000 {
- compatible = "fsl,imx7ulp-usdhc";
- reg = <0x40380000 0x10000>;
- interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&scg1 IMX7ULP_CLK_NIC1_BUS_DIV>,
- <&scg1 IMX7ULP_CLK_NIC1_DIV>,
- <&pcc2 IMX7ULP_CLK_USDHC1>;
- clock-names ="ipg", "ahb", "per";
- bus-width = <4>;
- };
diff --git a/Documentation/devicetree/bindings/clock/imx7ulp-scg-clock.yaml b/Documentation/devicetree/bindings/clock/imx7ulp-scg-clock.yaml
index ee8efb4ed599..d06344d7e34f 100644
--- a/Documentation/devicetree/bindings/clock/imx7ulp-scg-clock.yaml
+++ b/Documentation/devicetree/bindings/clock/imx7ulp-scg-clock.yaml
@@ -86,14 +86,3 @@ examples:
"firc", "upll";
#clock-cells = <1>;
};
-
- mmc@40380000 {
- compatible = "fsl,imx7ulp-usdhc";
- reg = <0x40380000 0x10000>;
- interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&scg1 IMX7ULP_CLK_NIC1_BUS_DIV>,
- <&scg1 IMX7ULP_CLK_NIC1_DIV>,
- <&pcc2 IMX7ULP_CLK_USDHC1>;
- clock-names ="ipg", "ahb", "per";
- bus-width = <4>;
- };
diff --git a/Documentation/devicetree/bindings/clock/imx8qxp-lpcg.yaml b/Documentation/devicetree/bindings/clock/imx8qxp-lpcg.yaml
index 0f6fe365ebf3..cb80105b3c70 100644
--- a/Documentation/devicetree/bindings/clock/imx8qxp-lpcg.yaml
+++ b/Documentation/devicetree/bindings/clock/imx8qxp-lpcg.yaml
@@ -101,14 +101,3 @@ examples:
"sdhc0_lpcg_ahb_clk";
power-domains = <&pd IMX_SC_R_SDHC_0>;
};
-
- mmc@5b010000 {
- compatible = "fsl,imx8qxp-usdhc", "fsl,imx7d-usdhc";
- interrupts = <GIC_SPI 232 IRQ_TYPE_LEVEL_HIGH>;
- reg = <0x5b010000 0x10000>;
- clocks = <&sdhc0_lpcg IMX_LPCG_CLK_4>,
- <&sdhc0_lpcg IMX_LPCG_CLK_5>,
- <&sdhc0_lpcg IMX_LPCG_CLK_0>;
- clock-names = "ipg", "ahb", "per";
- power-domains = <&pd IMX_SC_R_SDHC_0>;
- };
diff --git a/Documentation/devicetree/bindings/clock/imxrt1050-clock.yaml b/Documentation/devicetree/bindings/clock/imxrt1050-clock.yaml
index 35fd08c143f4..03fc5c1a2939 100644
--- a/Documentation/devicetree/bindings/clock/imxrt1050-clock.yaml
+++ b/Documentation/devicetree/bindings/clock/imxrt1050-clock.yaml
@@ -57,11 +57,3 @@ examples:
clock-names = "osc";
#clock-cells = <1>;
};
-
- lpuart1: serial@40184000 {
- compatible = "fsl,imxrt1050-lpuart";
- reg = <0x40184000 0x4000>;
- interrupts = <20>;
- clocks = <&clks IMXRT1050_CLK_LPUART1>;
- clock-names = "ipg";
- };
diff --git a/Documentation/devicetree/bindings/clock/nvidia,tegra124-car.yaml b/Documentation/devicetree/bindings/clock/nvidia,tegra124-car.yaml
index ec7ab1483652..1b2181f6d440 100644
--- a/Documentation/devicetree/bindings/clock/nvidia,tegra124-car.yaml
+++ b/Documentation/devicetree/bindings/clock/nvidia,tegra124-car.yaml
@@ -106,10 +106,3 @@ examples:
#clock-cells = <1>;
#reset-cells = <1>;
};
-
- usb-controller@c5004000 {
- compatible = "nvidia,tegra20-ehci";
- reg = <0xc5004000 0x4000>;
- clocks = <&car TEGRA124_CLK_USB2>;
- resets = <&car TEGRA124_CLK_USB2>;
- };
diff --git a/Documentation/devicetree/bindings/clock/nvidia,tegra20-car.yaml b/Documentation/devicetree/bindings/clock/nvidia,tegra20-car.yaml
index f832abb7f11a..bee2dd4b29bf 100644
--- a/Documentation/devicetree/bindings/clock/nvidia,tegra20-car.yaml
+++ b/Documentation/devicetree/bindings/clock/nvidia,tegra20-car.yaml
@@ -97,10 +97,3 @@ examples:
power-domains = <&domain>;
};
};
-
- usb-controller@c5004000 {
- compatible = "nvidia,tegra20-ehci";
- reg = <0xc5004000 0x4000>;
- clocks = <&car TEGRA20_CLK_USB2>;
- resets = <&car TEGRA20_CLK_USB2>;
- };
--
2.32.0


2022-03-21 22:19:13

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH 2/2] dt-bindings: clock: drop useless consumer example

On Wed, Mar 16, 2022 at 02:08:58PM +0100, Krzysztof Kozlowski wrote:
> Consumer examples in the bindings of resource providers are trivial,
> useless and duplication of code. Remove the example code for consumer
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../bindings/clock/bitmain,bm1880-clk.yaml | 12 ------------
> .../devicetree/bindings/clock/idt,versaclock5.yaml | 7 -------
> .../devicetree/bindings/clock/imx1-clock.yaml | 9 ---------
> .../devicetree/bindings/clock/imx21-clock.yaml | 9 ---------
> .../devicetree/bindings/clock/imx23-clock.yaml | 9 ---------
> .../devicetree/bindings/clock/imx25-clock.yaml | 8 --------
> .../devicetree/bindings/clock/imx27-clock.yaml | 9 ---------
> .../devicetree/bindings/clock/imx28-clock.yaml | 9 ---------
> .../devicetree/bindings/clock/imx31-clock.yaml | 8 --------
> .../devicetree/bindings/clock/imx35-clock.yaml | 8 --------
> .../devicetree/bindings/clock/imx7ulp-pcc-clock.yaml | 11 -----------
> .../devicetree/bindings/clock/imx7ulp-scg-clock.yaml | 11 -----------
> .../devicetree/bindings/clock/imx8qxp-lpcg.yaml | 11 -----------
> .../devicetree/bindings/clock/imxrt1050-clock.yaml | 8 --------
> .../bindings/clock/nvidia,tegra124-car.yaml | 7 -------
> .../bindings/clock/nvidia,tegra20-car.yaml | 7 -------
> 16 files changed, 143 deletions(-)

Doesn't apply to my tree (no imxrt1050-clock.yaml), so

Acked-by: Rob Herring <[email protected]>

2022-03-22 02:12:08

by Jesse T

[permalink] [raw]
Subject: Re: [PATCH 2/2] dt-bindings: clock: drop useless consumer example



On 3/21/22 14:23, Rob Herring wrote:
> On Wed, Mar 16, 2022 at 02:08:58PM +0100, Krzysztof Kozlowski wrote:
>> Consumer examples in the bindings of resource providers are trivial,
>> useless and duplication of code. Remove the example code for consumer
>>
>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>> ---
>> .../bindings/clock/bitmain,bm1880-clk.yaml | 12 ------------
>> .../devicetree/bindings/clock/idt,versaclock5.yaml | 7 -------
>> .../devicetree/bindings/clock/imx1-clock.yaml | 9 ---------
>> .../devicetree/bindings/clock/imx21-clock.yaml | 9 ---------
>> .../devicetree/bindings/clock/imx23-clock.yaml | 9 ---------
>> .../devicetree/bindings/clock/imx25-clock.yaml | 8 --------
>> .../devicetree/bindings/clock/imx27-clock.yaml | 9 ---------
>> .../devicetree/bindings/clock/imx28-clock.yaml | 9 ---------
>> .../devicetree/bindings/clock/imx31-clock.yaml | 8 --------
>> .../devicetree/bindings/clock/imx35-clock.yaml | 8 --------
>> .../devicetree/bindings/clock/imx7ulp-pcc-clock.yaml | 11 -----------
>> .../devicetree/bindings/clock/imx7ulp-scg-clock.yaml | 11 -----------
>> .../devicetree/bindings/clock/imx8qxp-lpcg.yaml | 11 -----------
>> .../devicetree/bindings/clock/imxrt1050-clock.yaml | 8 --------
>> .../bindings/clock/nvidia,tegra124-car.yaml | 7 -------
>> .../bindings/clock/nvidia,tegra20-car.yaml | 7 -------
>> 16 files changed, 143 deletions(-)
>
> Doesn't apply to my tree (no imxrt1050-clock.yaml), so
merge against linux-next I can submit another patch if needed.
> Acked-by: Rob Herring <[email protected]>

2022-03-22 10:07:35

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 2/2] dt-bindings: clock: drop useless consumer example

On 22/03/2022 09:45, Krzysztof Kozlowski wrote:
> On 22/03/2022 02:45, Jesse Taube wrote:
>>
>>
>> On 3/21/22 14:23, Rob Herring wrote:
>>> On Wed, Mar 16, 2022 at 02:08:58PM +0100, Krzysztof Kozlowski wrote:
>>>> Consumer examples in the bindings of resource providers are trivial,
>>>> useless and duplication of code. Remove the example code for consumer
>>>>
>>>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>>>> ---
>>>> .../bindings/clock/bitmain,bm1880-clk.yaml | 12 ------------
>>>> .../devicetree/bindings/clock/idt,versaclock5.yaml | 7 -------
>>>> .../devicetree/bindings/clock/imx1-clock.yaml | 9 ---------
>>>> .../devicetree/bindings/clock/imx21-clock.yaml | 9 ---------
>>>> .../devicetree/bindings/clock/imx23-clock.yaml | 9 ---------
>>>> .../devicetree/bindings/clock/imx25-clock.yaml | 8 --------
>>>> .../devicetree/bindings/clock/imx27-clock.yaml | 9 ---------
>>>> .../devicetree/bindings/clock/imx28-clock.yaml | 9 ---------
>>>> .../devicetree/bindings/clock/imx31-clock.yaml | 8 --------
>>>> .../devicetree/bindings/clock/imx35-clock.yaml | 8 --------
>>>> .../devicetree/bindings/clock/imx7ulp-pcc-clock.yaml | 11 -----------
>>>> .../devicetree/bindings/clock/imx7ulp-scg-clock.yaml | 11 -----------
>>>> .../devicetree/bindings/clock/imx8qxp-lpcg.yaml | 11 -----------
>>>> .../devicetree/bindings/clock/imxrt1050-clock.yaml | 8 --------
>>>> .../bindings/clock/nvidia,tegra124-car.yaml | 7 -------
>>>> .../bindings/clock/nvidia,tegra20-car.yaml | 7 -------
>>>> 16 files changed, 143 deletions(-)
>>>
>>> Doesn't apply to my tree (no imxrt1050-clock.yaml), so
>> merge against linux-next I can submit another patch if needed.
>>> Acked-by: Rob Herring <[email protected]>
>
> Let me send it after the merge window - all dependencies should be there.

Optionally this could be picked up by Stephen/Michael (clock).


Best regards,
Krzysztof

2022-03-22 14:17:56

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 2/2] dt-bindings: clock: drop useless consumer example

On 22/03/2022 02:45, Jesse Taube wrote:
>
>
> On 3/21/22 14:23, Rob Herring wrote:
>> On Wed, Mar 16, 2022 at 02:08:58PM +0100, Krzysztof Kozlowski wrote:
>>> Consumer examples in the bindings of resource providers are trivial,
>>> useless and duplication of code. Remove the example code for consumer
>>>
>>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>>> ---
>>> .../bindings/clock/bitmain,bm1880-clk.yaml | 12 ------------
>>> .../devicetree/bindings/clock/idt,versaclock5.yaml | 7 -------
>>> .../devicetree/bindings/clock/imx1-clock.yaml | 9 ---------
>>> .../devicetree/bindings/clock/imx21-clock.yaml | 9 ---------
>>> .../devicetree/bindings/clock/imx23-clock.yaml | 9 ---------
>>> .../devicetree/bindings/clock/imx25-clock.yaml | 8 --------
>>> .../devicetree/bindings/clock/imx27-clock.yaml | 9 ---------
>>> .../devicetree/bindings/clock/imx28-clock.yaml | 9 ---------
>>> .../devicetree/bindings/clock/imx31-clock.yaml | 8 --------
>>> .../devicetree/bindings/clock/imx35-clock.yaml | 8 --------
>>> .../devicetree/bindings/clock/imx7ulp-pcc-clock.yaml | 11 -----------
>>> .../devicetree/bindings/clock/imx7ulp-scg-clock.yaml | 11 -----------
>>> .../devicetree/bindings/clock/imx8qxp-lpcg.yaml | 11 -----------
>>> .../devicetree/bindings/clock/imxrt1050-clock.yaml | 8 --------
>>> .../bindings/clock/nvidia,tegra124-car.yaml | 7 -------
>>> .../bindings/clock/nvidia,tegra20-car.yaml | 7 -------
>>> 16 files changed, 143 deletions(-)
>>
>> Doesn't apply to my tree (no imxrt1050-clock.yaml), so
> merge against linux-next I can submit another patch if needed.
>> Acked-by: Rob Herring <[email protected]>

Let me send it after the merge window - all dependencies should be there.


Best regards,
Krzysztof