2022-03-17 03:42:23

by Bill Wendling

Subject: [PATCH] vlan: use correct format characters

When compiling with -Wformat, clang emits the following warning:

net/8021q/vlanproc.c:284:22: warning: format specifies type 'unsigned
short' but the argument has type 'int' [-Wformat]
mp->priority, ((mp->vlan_qos >> 13) & 0x7));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~

The types of these arguments are unconditionally defined, so this patch
updates the format character to the correct ones for ints and unsigned
ints.

Link: ClangBuiltLinux/linux#378
Signed-off-by: Bill Wendling <[email protected]>
---
net/8021q/vlanproc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/8021q/vlanproc.c b/net/8021q/vlanproc.c
index 08bf6c839e25..7825c129742a 100644
--- a/net/8021q/vlanproc.c
+++ b/net/8021q/vlanproc.c
@@ -280,7 +280,7 @@ static int vlandev_seq_show(struct seq_file *seq, void *offset)
const struct vlan_priority_tci_mapping *mp
= vlan->egress_priority_map[i];
while (mp) {
- seq_printf(seq, "%u:%hu ",
+ seq_printf(seq, "%u:%d ",
mp->priority, ((mp->vlan_qos >> 13) & 0x7));
mp = mp->next;
}
--
2.35.1.723.g4982287a31-goog

2022-03-18 00:12:41

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] vlan: use correct format characters

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <[email protected]>:

On Wed, 16 Mar 2022 14:31:25 -0700 you wrote:
> When compiling with -Wformat, clang emits the following warning:
>
> net/8021q/vlanproc.c:284:22: warning: format specifies type 'unsigned
> short' but the argument has type 'int' [-Wformat]
> mp->priority, ((mp->vlan_qos >> 13) & 0x7));
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> [...]

Here is the summary with links:
- vlan: use correct format characters
https://git.kernel.org/netdev/net-next/c/8624a95ecdea

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html