2022-03-17 03:05:08

by Kuldeep Singh

Subject: [PATCH 1/3] dt-bindings: timer: Rearrange compatible entries of arch timer

Compatibles entries of arch timer includes few extra items and enum
pairs which are redundant and can be simplified in a more clear, concise
and readable way. Do it.

Signed-off-by: Kuldeep Singh <[email protected]>
---
.../devicetree/bindings/timer/arm,arch_timer.yaml | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml b/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml
index df8ce87fd54b..ba2910f0a7b2 100644
--- a/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml
+++ b/Documentation/devicetree/bindings/timer/arm,arch_timer.yaml
@@ -21,17 +21,13 @@ description: |+
properties:
compatible:
oneOf:
+ - enum:
+ - arm,armv7-timer
+ - arm,armv8-timer
- items:
- enum:
- arm,cortex-a15-timer
- - enum:
- - arm,armv7-timer
- - items:
- - enum:
- - arm,armv7-timer
- - items:
- - enum:
- - arm,armv8-timer
+ - const: arm,armv7-timer

interrupts:
minItems: 1
--
2.25.1

2022-03-17 06:36:29

by Krzysztof Kozlowski

Subject: Re: [PATCH 1/3] dt-bindings: timer: Rearrange compatible entries of arch timer

On 16/03/2022 10:54, Kuldeep Singh wrote:
> Compatibles entries of arch timer includes few extra items and enum
> pairs which are redundant and can be simplified in a more clear, concise
> and readable way. Do it.
>
> Signed-off-by: Kuldeep Singh <[email protected]>
> ---
> .../devicetree/bindings/timer/arm,arch_timer.yaml | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>


Reviewed-by: Krzysztof Kozlowski <[email protected]>


Best regards,
Krzysztof

2022-03-17 07:54:16

by Kuldeep Singh

Subject: Re: [PATCH 1/3] dt-bindings: timer: Rearrange compatible entries of arch timer

On Wed, Mar 16, 2022 at 05:29:07PM +0100, Krzysztof Kozlowski wrote:
> On 16/03/2022 10:54, Kuldeep Singh wrote:
> > Compatibles entries of arch timer includes few extra items and enum
> > pairs which are redundant and can be simplified in a more clear, concise
> > and readable way. Do it.
> >
> > Signed-off-by: Kuldeep Singh <[email protected]>
> > ---
> > .../devicetree/bindings/timer/arm,arch_timer.yaml | 12 ++++--------
> > 1 file changed, 4 insertions(+), 8 deletions(-)
> >
>
>
> Reviewed-by: Krzysztof Kozlowski <[email protected]>
>

Thanks for your time in reviewing this.

- Kuldeep