2022-03-17 14:57:43

by Wang Weiyang

Subject: [PATCH -next] mtd: rawnand: davinci: Remove redundant unsigned comparison to zero

Since core_chipsel is uint32_t, comparison to zero is redundant

Signed-off-by: Wang Weiyang <[email protected]>
---
drivers/mtd/nand/raw/davinci_nand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/raw/davinci_nand.c b/drivers/mtd/nand/raw/davinci_nand.c
index 45fec8c192ab..3e98e3c255bf 100644
--- a/drivers/mtd/nand/raw/davinci_nand.c
+++ b/drivers/mtd/nand/raw/davinci_nand.c
@@ -727,7 +727,7 @@ static int nand_davinci_probe(struct platform_device *pdev)
return -ENODEV;

/* which external chipselect will we be managing? */
- if (pdata->core_chipsel < 0 || pdata->core_chipsel > 3)
+ if (pdata->core_chipsel > 3)
return -ENODEV;

info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL);
--
2.17.1

2022-04-05 01:05:05

by Miquel Raynal

Subject: Re: [PATCH -next] mtd: rawnand: davinci: Remove redundant unsigned comparison to zero

On Thu, 2022-03-17 at 11:39:07 UTC, Wang Weiyang wrote:
> Since core_chipsel is uint32_t, comparison to zero is redundant
>
> Signed-off-by: Wang Weiyang <[email protected]>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel