2022-03-17 20:09:34

by Leo Li

Subject: [PATCH 6/6] arm64: dts: ls208x: remove NXP Erratum A008585 from LS2088A.

From: Pankaj Bansal <[email protected]>

NXP Erratum A008585 affects A57 core cluster used in LS2085rev1.
However this problem has been fixed in A72 core cluster used in LS2088.
Therefore remove the erratum from LS2088A. Keeping it only in LS2085.

Signed-off-by: Pankaj Bansal <[email protected]>
Reviewed-by: Sandeep Malik <[email protected]>
Acked-by: Priyanka Jain <[email protected]>
---
arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi | 4 ++++
arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 3 +--
2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi
index 6f6667b70028..a2cadf757148 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi
@@ -150,3 +150,7 @@ &pcie4 {
ranges = <0x81000000 0x0 0x00000000 0x16 0x00010000 0x0 0x00010000 /* downstream I/O */
0x82000000 0x0 0x40000000 0x16 0x40000000 0x0 0x40000000>; /* non-prefetchable memory */
};
+
+&timer {
+ fsl,erratum-a008585;
+};
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
index 3cb9c21d2775..d823d54a01a5 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
@@ -239,13 +239,12 @@ map0 {
};
};

- timer {
+ timer: timer {
compatible = "arm,armv8-timer";
interrupts = <1 13 4>, /* Physical Secure PPI, active-low */
<1 14 4>, /* Physical Non-Secure PPI, active-low */
<1 11 4>, /* Virtual PPI, active-low */
<1 10 4>; /* Hypervisor PPI, active-low */
- fsl,erratum-a008585;
};

pmu {
--
2.25.1

2022-04-11 08:18:02

by Shawn Guo

Subject: Re: [PATCH 6/6] arm64: dts: ls208x: remove NXP Erratum A008585 from LS2088A.

On Thu, Mar 17, 2022 at 02:01:09PM -0500, Li Yang wrote:
> From: Pankaj Bansal <[email protected]>
>
> NXP Erratum A008585 affects A57 core cluster used in LS2085rev1.

s/LS2085rev1/LS2085 rev1

Shawn

> However this problem has been fixed in A72 core cluster used in LS2088.
> Therefore remove the erratum from LS2088A. Keeping it only in LS2085.
>
> Signed-off-by: Pankaj Bansal <[email protected]>
> Reviewed-by: Sandeep Malik <[email protected]>
> Acked-by: Priyanka Jain <[email protected]>
> ---
> arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi | 4 ++++
> arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 3 +--
> 2 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi
> index 6f6667b70028..a2cadf757148 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi
> @@ -150,3 +150,7 @@ &pcie4 {
> ranges = <0x81000000 0x0 0x00000000 0x16 0x00010000 0x0 0x00010000 /* downstream I/O */
> 0x82000000 0x0 0x40000000 0x16 0x40000000 0x0 0x40000000>; /* non-prefetchable memory */
> };
> +
> +&timer {
> + fsl,erratum-a008585;
> +};
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
> index 3cb9c21d2775..d823d54a01a5 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
> @@ -239,13 +239,12 @@ map0 {
> };
> };
>
> - timer {
> + timer: timer {
> compatible = "arm,armv8-timer";
> interrupts = <1 13 4>, /* Physical Secure PPI, active-low */
> <1 14 4>, /* Physical Non-Secure PPI, active-low */
> <1 11 4>, /* Virtual PPI, active-low */
> <1 10 4>; /* Hypervisor PPI, active-low */
> - fsl,erratum-a008585;
> };
>
> pmu {
> --
> 2.25.1
>