2022-03-18 14:49:09

by Jiabing Wan

Subject: [PATCH] qed: remove unnecessary memset in qed_init_fw_funcs

allocated_mem is allocated by kcalloc(). The memory is set to zero.
It is unnecessary to call memset again.

Signed-off-by: Wan Jiabing <[email protected]>
---
drivers/net/ethernet/qlogic/qed/qed_init_fw_funcs.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/qlogic/qed/qed_init_fw_funcs.c b/drivers/net/ethernet/qlogic/qed/qed_init_fw_funcs.c
index 0ce37f2460a4..407029a36fa1 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_init_fw_funcs.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_init_fw_funcs.c
@@ -1835,8 +1835,6 @@ struct phys_mem_desc *qed_fw_overlay_mem_alloc(struct qed_hwfn *p_hwfn,
if (!allocated_mem)
return NULL;

- memset(allocated_mem, 0, NUM_STORMS * sizeof(struct phys_mem_desc));
-
/* For each Storm, set physical address in RAM */
while (buf_offset < buf_size) {
struct phys_mem_desc *storm_mem_desc;
--
2.35.1

2022-03-21 23:25:39

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] qed: remove unnecessary memset in qed_init_fw_funcs

Hello:

This patch was applied to netdev/net-next.git (master)
by David S. Miller <[email protected]>:

On Fri, 18 Mar 2022 17:31:53 +0800 you wrote:
> allocated_mem is allocated by kcalloc(). The memory is set to zero.
> It is unnecessary to call memset again.
>
> Signed-off-by: Wan Jiabing <[email protected]>
> ---
> drivers/net/ethernet/qlogic/qed/qed_init_fw_funcs.c | 2 --
> 1 file changed, 2 deletions(-)

Here is the summary with links:
- qed: remove unnecessary memset in qed_init_fw_funcs
https://git.kernel.org/netdev/net-next/c/b8f7544a6cb3

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html