2022-03-19 08:14:38

by Alexandru Tachici

Subject: [PATCH v2 7/8] iio: adc: ad7124: add disable_all() callback

From: Alexandru Tachici <[email protected]>

Add the disable all callback to the ad_sigma_delta_info struct.

Signed-off-by: Alexandru Tachici <[email protected]>
---
drivers/iio/adc/ad7124.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)

diff --git a/drivers/iio/adc/ad7124.c b/drivers/iio/adc/ad7124.c
index 782b7cdd8ebe..3214079ff05f 100644
--- a/drivers/iio/adc/ad7124.c
+++ b/drivers/iio/adc/ad7124.c
@@ -524,9 +524,25 @@ static int ad7124_append_status(struct ad_sigma_delta *sd, bool append)
return ad_sd_write_reg(&st->sd, AD7124_ADC_CONTROL, 2, st->adc_control);
}

+static int ad7124_disable_all(struct ad_sigma_delta *sd)
+{
+ struct ad7124_state *st = container_of(sd, struct ad7124_state, sd);
+ int ret;
+ int i;
+
+ for (i = 0; i < st->num_channels; i++) {
+ ret = ad7124_spi_write_mask(st, AD7124_CHANNEL(i), AD7124_CHANNEL_EN_MSK, 0, 2);
+ if (ret < 0)
+ return ret;
+ }
+
+ return 0;
+}
+
static const struct ad_sigma_delta_info ad7124_sigma_delta_info = {
.set_channel = ad7124_set_channel,
.append_status = ad7124_append_status,
+ .disable_all = ad7124_disable_all,
.set_mode = ad7124_set_mode,
.has_registers = true,
.addr_shift = 0,
--
2.25.1

2022-03-21 01:40:02

by Jonathan Cameron

Subject: Re: [PATCH v2 7/8] iio: adc: ad7124: add disable_all() callback

On Fri, 18 Mar 2022 18:27:21 +0200
<[email protected]> wrote:

> From: Alexandru Tachici <[email protected]>
>
> Add the disable all callback to the ad_sigma_delta_info struct.
>
> Signed-off-by: Alexandru Tachici <[email protected]>

I think patch 5 leaves a non working driver as this will be required
for slots > 1. So squash this with patch 5.

> ---
> drivers/iio/adc/ad7124.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/drivers/iio/adc/ad7124.c b/drivers/iio/adc/ad7124.c
> index 782b7cdd8ebe..3214079ff05f 100644
> --- a/drivers/iio/adc/ad7124.c
> +++ b/drivers/iio/adc/ad7124.c
> @@ -524,9 +524,25 @@ static int ad7124_append_status(struct ad_sigma_delta *sd, bool append)
> return ad_sd_write_reg(&st->sd, AD7124_ADC_CONTROL, 2, st->adc_control);
> }
>
> +static int ad7124_disable_all(struct ad_sigma_delta *sd)
> +{
> + struct ad7124_state *st = container_of(sd, struct ad7124_state, sd);
> + int ret;
> + int i;
> +
> + for (i = 0; i < st->num_channels; i++) {
> + ret = ad7124_spi_write_mask(st, AD7124_CHANNEL(i), AD7124_CHANNEL_EN_MSK, 0, 2);
> + if (ret < 0)
> + return ret;
> + }
> +
> + return 0;
> +}
> +
> static const struct ad_sigma_delta_info ad7124_sigma_delta_info = {
> .set_channel = ad7124_set_channel,
> .append_status = ad7124_append_status,
> + .disable_all = ad7124_disable_all,
> .set_mode = ad7124_set_mode,
> .has_registers = true,
> .addr_shift = 0,