2022-03-21 22:58:39

by Adam Ford

Subject: [PATCH V2] soc: imx: imx8m-blk-ctrl: Fix IMX8MN_DISPBLK_PD_ISI hang

The imx8mn clock list for the ISI lists four clocks, but DOMAIN_MAX_CLKS
was set to 3. Because of this, attempts to enable the fourth clock failed,
threw some splat, and ultimately hung.

Fixes: 7f511d514e8c ("soc: imx: imx8m-blk-ctrl: add i.MX8MN DISP blk-ctrl")
Signed-off-by: Adam Ford <[email protected]>

diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c b/drivers/soc/imx/imx8m-blk-ctrl.c
index a0a0d2d7ca4a..7109f0d508e2 100644
--- a/drivers/soc/imx/imx8m-blk-ctrl.c
+++ b/drivers/soc/imx/imx8m-blk-ctrl.c
@@ -50,7 +50,7 @@ struct imx8m_blk_ctrl_domain_data {
u32 mipi_phy_rst_mask;
};

-#define DOMAIN_MAX_CLKS 3
+#define DOMAIN_MAX_CLKS 4

struct imx8m_blk_ctrl_domain {
struct generic_pm_domain genpd;
--
2.34.1

2022-04-11 14:19:30

by Shawn Guo

Subject: Re: [PATCH V2] soc: imx: imx8m-blk-ctrl: Fix IMX8MN_DISPBLK_PD_ISI hang

On Sun, Mar 20, 2022 at 03:52:12PM -0500, Adam Ford wrote:
> The imx8mn clock list for the ISI lists four clocks, but DOMAIN_MAX_CLKS
> was set to 3. Because of this, attempts to enable the fourth clock failed,
> threw some splat, and ultimately hung.
>
> Fixes: 7f511d514e8c ("soc: imx: imx8m-blk-ctrl: add i.MX8MN DISP blk-ctrl")
> Signed-off-by: Adam Ford <[email protected]>

Applied, thanks!