2022-03-21 20:35:24

by Fabio Baltieri

Subject: [PATCH 1/4] dt-bindings: add mfd/cros_ec definitions

Add a dt-bindings include file for cros_ec devicetree definition, define
a pair of special purpose PWM channels in it.

Signed-off-by: Fabio Baltieri <[email protected]>
---
include/dt-bindings/mfd/cros_ec.h | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
create mode 100644 include/dt-bindings/mfd/cros_ec.h

diff --git a/include/dt-bindings/mfd/cros_ec.h b/include/dt-bindings/mfd/cros_ec.h
new file mode 100644
index 000000000000..e02414eae622
--- /dev/null
+++ b/include/dt-bindings/mfd/cros_ec.h
@@ -0,0 +1,18 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+/*
+ * DTS binding definitions used for the Chromium OS Embedded Controller.
+ *
+ * Copyright (c) 2022 The Chromium OS Authors. All rights reserved.
+ */
+
+#ifndef _DT_BINDINGS_MFD_CROS_EC_H
+#define _DT_BINDINGS_MFD_CROS_EC_H
+
+/* Typed channel for keyboard backlight. */
+#define CROS_EC_PWM_DT_KB_LIGHT 0
+/* Typed channel for display backlight. */
+#define CROS_EC_PWM_DT_DISPLAY_LIGHT 1
+/* Number of typed channels. */
+#define CROS_EC_PWM_DT_COUNT 2
+
+#endif
--
2.35.1.894.gb6a874cedc-goog

2022-03-21 22:56:41

by Krzysztof Kozlowski

Subject: Re: [PATCH 1/4] dt-bindings: add mfd/cros_ec definitions

On 21/03/2022 15:32, Fabio Baltieri wrote:
> Add a dt-bindings include file for cros_ec devicetree definition, define
> a pair of special purpose PWM channels in it.
>
> Signed-off-by: Fabio Baltieri <[email protected]>
> ---
> include/dt-bindings/mfd/cros_ec.h | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
> create mode 100644 include/dt-bindings/mfd/cros_ec.h
>
> diff --git a/include/dt-bindings/mfd/cros_ec.h b/include/dt-bindings/mfd/cros_ec.h
> new file mode 100644
> index 000000000000..e02414eae622
> --- /dev/null
> +++ b/include/dt-bindings/mfd/cros_ec.h
> @@ -0,0 +1,18 @@
> +/* SPDX-License-Identifier: GPL-2.0-or-later */

Same license as for bindings (GPL-2.0-only OR BSD-2-Clause), unless you
cannot (is it a derivative work?).


Best regards,
Krzysztof

2022-03-22 14:18:18

by Fabio Baltieri

Subject: Re: [PATCH 1/4] dt-bindings: add mfd/cros_ec definitions

On Mon, Mar 21, 2022 at 04:46:49PM +0100, Krzysztof Kozlowski wrote:
> On 21/03/2022 15:32, Fabio Baltieri wrote:
> > Add a dt-bindings include file for cros_ec devicetree definition, define
> > a pair of special purpose PWM channels in it.
> >
> > Signed-off-by: Fabio Baltieri <[email protected]>
> > ---
> > include/dt-bindings/mfd/cros_ec.h | 18 ++++++++++++++++++
> > 1 file changed, 18 insertions(+)
> > create mode 100644 include/dt-bindings/mfd/cros_ec.h
> >
> > diff --git a/include/dt-bindings/mfd/cros_ec.h b/include/dt-bindings/mfd/cros_ec.h
> > new file mode 100644
> > index 000000000000..e02414eae622
> > --- /dev/null
> > +++ b/include/dt-bindings/mfd/cros_ec.h
> > @@ -0,0 +1,18 @@
> > +/* SPDX-License-Identifier: GPL-2.0-or-later */
>
> Same license as for bindings (GPL-2.0-only OR BSD-2-Clause), unless you
> cannot (is it a derivative work?).

Ack, it's not, will change in v2, thanks!

>
>
> Best regards,
> Krzysztof

--
Fabio Baltieri