2022-03-25 17:41:55

by Axel Rasmussen

Subject: [PATCH 2/2] selftests: fix an unused variable warning in pidfd selftest

I fixed a few warnings like this in commit e2aa5e650b07
("selftests: fixup build warnings in pidfd / clone3 tests"), but I
missed this one by mistake. Since this variable is unused, remove it.

Signed-off-by: Axel Rasmussen <[email protected]>
---
tools/testing/selftests/pidfd/pidfd_wait.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/tools/testing/selftests/pidfd/pidfd_wait.c b/tools/testing/selftests/pidfd/pidfd_wait.c
index 17999e082aa7..070c1c876df1 100644
--- a/tools/testing/selftests/pidfd/pidfd_wait.c
+++ b/tools/testing/selftests/pidfd/pidfd_wait.c
@@ -95,7 +95,6 @@ TEST(wait_states)
.flags = CLONE_PIDFD | CLONE_PARENT_SETTID,
.exit_signal = SIGCHLD,
};
- int ret;
pid_t pid;
siginfo_t info = {
.si_signo = 0,
--
2.35.1.1021.g381101b075-goog

2022-03-25 18:56:23

by Christian Brauner

Subject: Re: [PATCH 2/2] selftests: fix an unused variable warning in pidfd selftest

On Thu, Mar 24, 2022 at 03:39:29PM -0700, Axel Rasmussen wrote:
> I fixed a few warnings like this in commit e2aa5e650b07
> ("selftests: fixup build warnings in pidfd / clone3 tests"), but I
> missed this one by mistake. Since this variable is unused, remove it.
>
> Signed-off-by: Axel Rasmussen <[email protected]>
> ---

Looks good,
Reviewed-by: Christian Brauner <[email protected]>

2022-03-25 20:36:14

by Shuah Khan

Subject: Re: [PATCH 2/2] selftests: fix an unused variable warning in pidfd selftest

On 3/25/22 9:21 AM, Christian Brauner wrote:
> On Thu, Mar 24, 2022 at 03:39:29PM -0700, Axel Rasmussen wrote:
>> I fixed a few warnings like this in commit e2aa5e650b07
>> ("selftests: fixup build warnings in pidfd / clone3 tests"), but I
>> missed this one by mistake. Since this variable is unused, remove it.
>>
>> Signed-off-by: Axel Rasmussen <[email protected]>
>> ---
>
> Looks good,
> Reviewed-by: Christian Brauner <[email protected]>
>

Thank you both. Will apply it for Linux 5.18-rc2.

thanks,
-- Shuah