2022-03-25 19:35:38

by Gireesh.Hiremath

[permalink] [raw]
Subject: [PATCH 00/15] am335x, guardian: update board specific dts changes

From: Gireesh Hiremath <[email protected]>

update guardian device tree

Gireesh Hiremath (15):
ARM: dts: am335x: Guardian: Update NAND partition table
ARM: dts: am335x: Guardian: Rename power button label
ARM: dts: am335x: Guardian: Add keypad
ARM: dts: am335x: Guardian: Disable poweroff support from RTC
ARM: dts: am335x: Guardian: Remove mmc status led
ARM: dts: am335x: Guardian: Update life led
ARM: dts: am335x: Guardian: Update beeper label
ARM: dts: am335x: Guardian: Update regulator node name
ARM: dts: am335x: Guardian: Add lcd port
ARM: dts: am335x: Guardian: Update backlight parameter
ARM: dts: am335x: Guardian: Enable UART port two
ARM: dts: am335x: Guardian: Disable DMA property of USB1
ARM: dts: am335x: Guardian: Update interface pinmux
ARM: dts: am335x: Guardian: Add gpio line manes
ARM: dts: am335x: Guardian: Update comments

arch/arm/boot/dts/am335x-guardian.dts | 376 ++++++++++++++++++++++----
1 file changed, 316 insertions(+), 60 deletions(-)

--
2.20.1


2022-03-25 19:58:40

by Gireesh.Hiremath

[permalink] [raw]
Subject: [PATCH 05/15] ARM: dts: am335x: Guardian: Remove mmc status led

From: Gireesh Hiremath <[email protected]>

* MMC presence indicater LED removed from Guardian Board

Signed-off-by: Gireesh Hiremath <[email protected]>
---
arch/arm/boot/dts/am335x-guardian.dts | 9 ---------
1 file changed, 9 deletions(-)

diff --git a/arch/arm/boot/dts/am335x-guardian.dts b/arch/arm/boot/dts/am335x-guardian.dts
index 46314f1bc85b..749239081bf1 100644
--- a/arch/arm/boot/dts/am335x-guardian.dts
+++ b/arch/arm/boot/dts/am335x-guardian.dts
@@ -51,7 +51,6 @@
};
};

-
leds {
compatible = "gpio-leds";
pinctrl-names = "default";
@@ -63,13 +62,6 @@
linux,default-trigger = "heartbeat";
default-state = "off";
};
-
- led2 {
- label = "green:mmc0";
- gpios = <&gpio1 26 GPIO_ACTIVE_HIGH>;
- linux,default-trigger = "mmc0";
- default-state = "off";
- };
};

panel {
@@ -475,7 +467,6 @@

leds_pins: pinmux_leds_pins {
pinctrl-single,pins = <
- AM33XX_IOPAD(0x868, PIN_OUTPUT | MUX_MODE7)
AM33XX_IOPAD(0x86c, PIN_OUTPUT | MUX_MODE7)
>;
};
--
2.20.1

2022-04-22 22:50:15

by Tony Lindgren

[permalink] [raw]
Subject: Re: [PATCH 00/15] am335x, guardian: update board specific dts changes

* [email protected] <[email protected]> [220325 12:04]:
> From: Gireesh Hiremath <[email protected]>
>
> update guardian device tree

Thanks applying into omap-for-v5.19/dt.

Few ideas for future though.

Not sure how you handle the nand partition table changes.. Seems the partition
values in the devicetree should not change in general.

The node names in devicetree should not use "_" but "-" instead. And the node
names should be general like you mostly already have. Anyways, we have a lot
of these especially for pinctrl, but we may want to clean them up eventually.
Just FYI.

Regards,

Tony