2022-03-26 17:01:35

by Jesse T

Subject: [PATCH v1 02/12] dt-bindings: timer: gpt: Add i.MXRT compatible Documentation

Both the i.MXRT1170 and 1050 have the same GPT timer as "fsl,imx6dl-gpt"
Add i.MXRT to the compatible list.

Signed-off-by: Jesse Taube <[email protected]>
---
Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
index a4f51f46b7a1..716c6afcca1f 100644
--- a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
+++ b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
@@ -31,6 +31,8 @@ properties:
- enum:
- fsl,imx6sl-gpt
- fsl,imx6sx-gpt
+ - fsl,imxrt1050-gpt
+ - fsl,imxrt1170-gpt
- const: fsl,imx6dl-gpt

reg:
--
2.34.1

2022-03-28 21:24:19

by Krzysztof Kozlowski

Subject: Re: [PATCH v1 02/12] dt-bindings: timer: gpt: Add i.MXRT compatible Documentation

On 26/03/2022 15:43, Jesse Taube wrote:
> Both the i.MXRT1170 and 1050 have the same GPT timer as "fsl,imx6dl-gpt"
> Add i.MXRT to the compatible list.
>
> Signed-off-by: Jesse Taube <[email protected]>
> ---
> Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> index a4f51f46b7a1..716c6afcca1f 100644
> --- a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> +++ b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> @@ -31,6 +31,8 @@ properties:
> - enum:
> - fsl,imx6sl-gpt
> - fsl,imx6sx-gpt
> + - fsl,imxrt1050-gpt
> + - fsl,imxrt1170-gpt
> - const: fsl,imx6dl-gpt

This looks ok, but your usage looks wrong. Did you test your DTS with
dtbs_check?

For the bindings only change:
Acked-by: Krzysztof Kozlowski <[email protected]>


Best regards,
Krzysztof