2022-03-28 21:36:34

by Yu Zhe

Subject: [PATCH] KVM: arm64: vgic-debug: remove unnecessary type castings

remove unnecessary castings, from "void *" to "struct kvm *"

Signed-off-by: yuzhe <[email protected]>
---
arch/arm64/kvm/vgic/vgic-debug.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/kvm/vgic/vgic-debug.c b/arch/arm64/kvm/vgic/vgic-debug.c
index f38c40a76251..927e5c1f650d 100644
--- a/arch/arm64/kvm/vgic/vgic-debug.c
+++ b/arch/arm64/kvm/vgic/vgic-debug.c
@@ -82,7 +82,7 @@ static bool end_of_vgic(struct vgic_state_iter *iter)

static void *vgic_debug_start(struct seq_file *s, loff_t *pos)
{
- struct kvm *kvm = (struct kvm *)s->private;
+ struct kvm *kvm = s->private;
struct vgic_state_iter *iter;

mutex_lock(&kvm->lock);
@@ -110,7 +110,7 @@ static void *vgic_debug_start(struct seq_file *s, loff_t *pos)

static void *vgic_debug_next(struct seq_file *s, void *v, loff_t *pos)
{
- struct kvm *kvm = (struct kvm *)s->private;
+ struct kvm *kvm = s->private;
struct vgic_state_iter *iter = kvm->arch.vgic.iter;

++*pos;
@@ -122,7 +122,7 @@ static void *vgic_debug_next(struct seq_file *s, void *v, loff_t *pos)

static void vgic_debug_stop(struct seq_file *s, void *v)
{
- struct kvm *kvm = (struct kvm *)s->private;
+ struct kvm *kvm = s->private;
struct vgic_state_iter *iter;

/*
@@ -229,7 +229,7 @@ static void print_irq_state(struct seq_file *s, struct vgic_irq *irq,

static int vgic_debug_show(struct seq_file *s, void *v)
{
- struct kvm *kvm = (struct kvm *)s->private;
+ struct kvm *kvm = s->private;
struct vgic_state_iter *iter = (struct vgic_state_iter *)v;
struct vgic_irq *irq;
struct kvm_vcpu *vcpu = NULL;
--
2.25.1

2022-03-28 22:08:43

by Marc Zyngier

Subject: Re: [PATCH] KVM: arm64: vgic-debug: remove unnecessary type castings

On Mon, 28 Mar 2022 11:38:36 +0100,
yuzhe <[email protected]> wrote:
>
> remove unnecessary castings, from "void *" to "struct kvm *"
>
> Signed-off-by: yuzhe <[email protected]>
> ---
> arch/arm64/kvm/vgic/vgic-debug.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/kvm/vgic/vgic-debug.c b/arch/arm64/kvm/vgic/vgic-debug.c
> index f38c40a76251..927e5c1f650d 100644
> --- a/arch/arm64/kvm/vgic/vgic-debug.c
> +++ b/arch/arm64/kvm/vgic/vgic-debug.c
> @@ -82,7 +82,7 @@ static bool end_of_vgic(struct vgic_state_iter *iter)
>
> static void *vgic_debug_start(struct seq_file *s, loff_t *pos)
> {
> - struct kvm *kvm = (struct kvm *)s->private;
> + struct kvm *kvm = s->private;
> struct vgic_state_iter *iter;
>
> mutex_lock(&kvm->lock);
> @@ -110,7 +110,7 @@ static void *vgic_debug_start(struct seq_file *s, loff_t *pos)
>
> static void *vgic_debug_next(struct seq_file *s, void *v, loff_t *pos)
> {
> - struct kvm *kvm = (struct kvm *)s->private;
> + struct kvm *kvm = s->private;
> struct vgic_state_iter *iter = kvm->arch.vgic.iter;
>
> ++*pos;
> @@ -122,7 +122,7 @@ static void *vgic_debug_next(struct seq_file *s, void *v, loff_t *pos)
>
> static void vgic_debug_stop(struct seq_file *s, void *v)
> {
> - struct kvm *kvm = (struct kvm *)s->private;
> + struct kvm *kvm = s->private;
> struct vgic_state_iter *iter;
>
> /*
> @@ -229,7 +229,7 @@ static void print_irq_state(struct seq_file *s, struct vgic_irq *irq,
>
> static int vgic_debug_show(struct seq_file *s, void *v)
> {
> - struct kvm *kvm = (struct kvm *)s->private;
> + struct kvm *kvm = s->private;
> struct vgic_state_iter *iter = (struct vgic_state_iter *)v;

How about you fully get rid of the unnecessary casts then?

M.

--
Without deviation from the norm, progress is not possible.

2022-03-29 10:00:10

by Yu Zhe

Subject: Re: [PATCH] KVM: arm64: vgic-debug: remove unnecessary type castings

在 2022/3/29 15:07, Marc Zyngier 写道:

> On Tue, 29 Mar 2022 07:14:16 +0100,
> yuzhe <[email protected]> wrote:
>>>> @@ -229,7 +229,7 @@ static void print_irq_state(struct seq_file *s, struct vgic_irq *irq,
>>>> static int vgic_debug_show(struct seq_file *s, void *v)
>>>> {
>>>> - struct kvm *kvm = (struct kvm *)s->private;
>>>> + struct kvm *kvm = s->private;
>>>> struct vgic_state_iter *iter = (struct vgic_state_iter *)v;
>>> How about you fully get rid of the unnecessary casts then?
>>>
>>> M.
>> I don't know what you exactly mean. I follow the
>> kernel-janitors/TODO List to get rid of the unnecessary casts. And
>> I checked all the code in the arch directory and found these issues.
> Let me quote the lines again:
>
>>>> static int vgic_debug_show(struct seq_file *s, void *v)
> [...]
>>>> struct vgic_state_iter *iter = (struct vgic_state_iter *)v;
> Do you see what I mean?
>
> M.

Got it, thanks. I will check again and resubmit.

yuzhe

2022-03-29 10:37:03

by Yu Zhe

Subject: Re: [PATCH] KVM: arm64: vgic-debug: remove unnecessary type castings

在 2022/3/28 21:36, Marc Zyngier 写道:

> On Mon, 28 Mar 2022 11:38:36 +0100,
> yuzhe <[email protected]> wrote:
>> remove unnecessary castings, from "void *" to "struct kvm *"
>>
>> Signed-off-by: yuzhe <[email protected]>
>> ---
>> arch/arm64/kvm/vgic/vgic-debug.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm64/kvm/vgic/vgic-debug.c b/arch/arm64/kvm/vgic/vgic-debug.c
>> index f38c40a76251..927e5c1f650d 100644
>> --- a/arch/arm64/kvm/vgic/vgic-debug.c
>> +++ b/arch/arm64/kvm/vgic/vgic-debug.c
>> @@ -82,7 +82,7 @@ static bool end_of_vgic(struct vgic_state_iter *iter)
>>
>> static void *vgic_debug_start(struct seq_file *s, loff_t *pos)
>> {
>> - struct kvm *kvm = (struct kvm *)s->private;
>> + struct kvm *kvm = s->private;
>> struct vgic_state_iter *iter;
>>
>> mutex_lock(&kvm->lock);
>> @@ -110,7 +110,7 @@ static void *vgic_debug_start(struct seq_file *s, loff_t *pos)
>>
>> static void *vgic_debug_next(struct seq_file *s, void *v, loff_t *pos)
>> {
>> - struct kvm *kvm = (struct kvm *)s->private;
>> + struct kvm *kvm = s->private;
>> struct vgic_state_iter *iter = kvm->arch.vgic.iter;
>>
>> ++*pos;
>> @@ -122,7 +122,7 @@ static void *vgic_debug_next(struct seq_file *s, void *v, loff_t *pos)
>>
>> static void vgic_debug_stop(struct seq_file *s, void *v)
>> {
>> - struct kvm *kvm = (struct kvm *)s->private;
>> + struct kvm *kvm = s->private;
>> struct vgic_state_iter *iter;
>>
>> /*
>> @@ -229,7 +229,7 @@ static void print_irq_state(struct seq_file *s, struct vgic_irq *irq,
>>
>> static int vgic_debug_show(struct seq_file *s, void *v)
>> {
>> - struct kvm *kvm = (struct kvm *)s->private;
>> + struct kvm *kvm = s->private;
>> struct vgic_state_iter *iter = (struct vgic_state_iter *)v;
> How about you fully get rid of the unnecessary casts then?
>
> M.

I don't know what you exactly mean. I follow the kernel-janitors/TODO List to get rid of the unnecessary casts.
And I checked all the code in the arch directory and found these issues.

2022-03-29 13:18:05

by Marc Zyngier

Subject: Re: [PATCH] KVM: arm64: vgic-debug: remove unnecessary type castings

On Tue, 29 Mar 2022 07:14:16 +0100,
yuzhe <[email protected]> wrote:
>
> >> @@ -229,7 +229,7 @@ static void print_irq_state(struct seq_file *s, struct vgic_irq *irq,
> >> static int vgic_debug_show(struct seq_file *s, void *v)
> >> {
> >> - struct kvm *kvm = (struct kvm *)s->private;
> >> + struct kvm *kvm = s->private;
> >> struct vgic_state_iter *iter = (struct vgic_state_iter *)v;
> > How about you fully get rid of the unnecessary casts then?
> >
> > M.
>
> I don't know what you exactly mean. I follow the
> kernel-janitors/TODO List to get rid of the unnecessary casts. And
> I checked all the code in the arch directory and found these issues.

Let me quote the lines again:

> >> static int vgic_debug_show(struct seq_file *s, void *v)
[...]
> >> struct vgic_state_iter *iter = (struct vgic_state_iter *)v;

Do you see what I mean?

M.

--
Without deviation from the norm, progress is not possible.

2022-03-29 15:30:34

by Yu Zhe

Subject: [PATCH] KVM: arm64: vgic: remove unnecessary type castings

remove unnecessary casts.

Signed-off-by: Yu Zhe <[email protected]>
---
arch/arm64/kvm/vgic/vgic-debug.c | 10 +++++-----
arch/arm64/kvm/vgic/vgic-its.c | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm64/kvm/vgic/vgic-debug.c b/arch/arm64/kvm/vgic/vgic-debug.c
index f38c40a76251..78cde687383c 100644
--- a/arch/arm64/kvm/vgic/vgic-debug.c
+++ b/arch/arm64/kvm/vgic/vgic-debug.c
@@ -82,7 +82,7 @@ static bool end_of_vgic(struct vgic_state_iter *iter)

static void *vgic_debug_start(struct seq_file *s, loff_t *pos)
{
- struct kvm *kvm = (struct kvm *)s->private;
+ struct kvm *kvm = s->private;
struct vgic_state_iter *iter;

mutex_lock(&kvm->lock);
@@ -110,7 +110,7 @@ static void *vgic_debug_start(struct seq_file *s, loff_t *pos)

static void *vgic_debug_next(struct seq_file *s, void *v, loff_t *pos)
{
- struct kvm *kvm = (struct kvm *)s->private;
+ struct kvm *kvm = s->private;
struct vgic_state_iter *iter = kvm->arch.vgic.iter;

++*pos;
@@ -122,7 +122,7 @@ static void *vgic_debug_next(struct seq_file *s, void *v, loff_t *pos)

static void vgic_debug_stop(struct seq_file *s, void *v)
{
- struct kvm *kvm = (struct kvm *)s->private;
+ struct kvm *kvm = s->private;
struct vgic_state_iter *iter;

/*
@@ -229,8 +229,8 @@ static void print_irq_state(struct seq_file *s, struct vgic_irq *irq,

static int vgic_debug_show(struct seq_file *s, void *v)
{
- struct kvm *kvm = (struct kvm *)s->private;
- struct vgic_state_iter *iter = (struct vgic_state_iter *)v;
+ struct kvm *kvm = s->private;
+ struct vgic_state_iter *iter = v;
struct vgic_irq *irq;
struct kvm_vcpu *vcpu = NULL;
unsigned long flags;
diff --git a/arch/arm64/kvm/vgic/vgic-its.c b/arch/arm64/kvm/vgic/vgic-its.c
index 089fc2ffcb43..2e13402be3bd 100644
--- a/arch/arm64/kvm/vgic/vgic-its.c
+++ b/arch/arm64/kvm/vgic/vgic-its.c
@@ -2143,7 +2143,7 @@ static int vgic_its_save_ite(struct vgic_its *its, struct its_device *dev,
static int vgic_its_restore_ite(struct vgic_its *its, u32 event_id,
void *ptr, void *opaque)
{
- struct its_device *dev = (struct its_device *)opaque;
+ struct its_device *dev = opaque;
struct its_collection *collection;
struct kvm *kvm = its->dev->kvm;
struct kvm_vcpu *vcpu = NULL;
--
2.25.1

2022-03-29 17:08:25

by Dan Carpenter

Subject: Re: [PATCH] KVM: arm64: vgic-debug: remove unnecessary type castings

On Tue, Mar 29, 2022 at 02:14:16PM +0800, yuzhe wrote:
> > > @@ -229,7 +229,7 @@ static void print_irq_state(struct seq_file *s, struct vgic_irq *irq,
> > > static int vgic_debug_show(struct seq_file *s, void *v)
> > > {
> > > - struct kvm *kvm = (struct kvm *)s->private;
> > > + struct kvm *kvm = s->private;
> > > struct vgic_state_iter *iter = (struct vgic_state_iter *)v;
^^^^^^^^^^^^^^^^^^^^^^^^^^
This cast is unnecessary. Look for others as well.

regards,
dan carpenter

2022-04-06 16:43:59

by Marc Zyngier

Subject: Re: [PATCH] KVM: arm64: vgic: remove unnecessary type castings

On Tue, 29 Mar 2022 03:20:59 -0700, Yu Zhe wrote:
> remove unnecessary casts.

Applied to fixes, thanks!

[1/1] KVM: arm64: vgic: remove unnecessary type castings
commit: c707663e81ef48d279719e97fd86acef835a2671

Cheers,

M.
--
Without deviation from the norm, progress is not possible.