2022-03-31 02:33:43

by Michael Tretter

[permalink] [raw]
Subject: Re: [PATCH -next] media: isl7998x: select V4L2_FWNODE to fix build error

On Tue, 29 Mar 2022 18:56:52 -0700, Randy Dunlap wrote:
> Fix build error when VIDEO_ISL7998X=y and V4L2_FWNODE=m
> by selecting V4L2_FWNODE.
>
> microblaze-linux-ld: drivers/media/i2c/isl7998x.o: in function `isl7998x_probe':
> (.text+0x8f4): undefined reference to `v4l2_fwnode_endpoint_parse'
>
> Fixes: 51ef2be546e2 ("media: i2c: isl7998x: Add driver for Intersil ISL7998x")
> Signed-off-by: Randy Dunlap <[email protected]>
> Reported-by: kernel test robot <[email protected]>
> Cc: Marek Vasut <[email protected]>
> Cc: Sakari Ailus <[email protected]>
> Cc: Michael Tretter <[email protected]>
> Cc: Pengutronix Kernel Team <[email protected]>
> Cc: [email protected]
> Cc: Mauro Carvalho Chehab <[email protected]>

Reviewed-by: Michael Tretter <[email protected]>

> ---
> drivers/media/i2c/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20220329.orig/drivers/media/i2c/Kconfig
> +++ linux-next-20220329/drivers/media/i2c/Kconfig
> @@ -1177,6 +1177,7 @@ config VIDEO_ISL7998X
> depends on OF_GPIO
> select MEDIA_CONTROLLER
> select VIDEO_V4L2_SUBDEV_API
> + select V4L2_FWNODE
> help
> Support for Intersil ISL7998x analog to MIPI-CSI2 or
> BT.656 decoder.
>