2022-03-31 02:47:20

by David Jander

Subject: [PATCH 2/2] dt-bindings: auxdisplay: holtek,ht16k33.yaml: Add holtek,refuse-primary-fb

Document the DT property that will cause the holtek auxdisplay driver to
back off if it detects that it is the first driver to probe a framebuffer
device.

Signed-off-by: David Jander <[email protected]>
---
.../devicetree/bindings/auxdisplay/holtek,ht16k33.yaml | 3 +++
1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/auxdisplay/holtek,ht16k33.yaml b/Documentation/devicetree/bindings/auxdisplay/holtek,ht16k33.yaml
index fc4873deb76f..4de32c3e26ce 100644
--- a/Documentation/devicetree/bindings/auxdisplay/holtek,ht16k33.yaml
+++ b/Documentation/devicetree/bindings/auxdisplay/holtek,ht16k33.yaml
@@ -53,6 +53,9 @@ properties:
$ref: /schemas/leds/common.yaml#
unevaluatedProperties: false

+ holtek,refuse-primary-fb:
+ description: Refuse to claim the first framebuffer device
+
required:
- compatible
- reg
--
2.32.0

2022-03-31 03:25:24

by Rob Herring

Subject: Re: [PATCH 2/2] dt-bindings: auxdisplay: holtek,ht16k33.yaml: Add holtek,refuse-primary-fb

On Wed, 30 Mar 2022 09:34:40 +0200, David Jander wrote:
> Document the DT property that will cause the holtek auxdisplay driver to
> back off if it detects that it is the first driver to probe a framebuffer
> device.
>
> Signed-off-by: David Jander <[email protected]>
> ---
> .../devicetree/bindings/auxdisplay/holtek,ht16k33.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/auxdisplay/holtek,ht16k33.yaml: properties:holtek,refuse-primary-fb: 'oneOf' conditional failed, one must be fixed:
'type' is a required property
hint: A vendor boolean property can use "type: boolean"
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/auxdisplay/holtek,ht16k33.yaml: properties:holtek,refuse-primary-fb: 'oneOf' conditional failed, one must be fixed:
'enum' is a required property
'const' is a required property
hint: A vendor string property with exact values has an implicit type
from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/auxdisplay/holtek,ht16k33.yaml: properties:holtek,refuse-primary-fb: 'oneOf' conditional failed, one must be fixed:
'$ref' is a required property
'allOf' is a required property
hint: A vendor property needs a $ref to types.yaml
from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/auxdisplay/holtek,ht16k33.yaml: ignoring, error in schema: properties: holtek,refuse-primary-fb
Documentation/devicetree/bindings/auxdisplay/holtek,ht16k33.example.dt.yaml:0:0: /example-0/i2c1/ht16k33@70: failed to match any schema with compatible: ['holtek,ht16k33']

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/1610969

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.

2022-03-31 04:15:58

by Rob Herring

Subject: Re: [PATCH 2/2] dt-bindings: auxdisplay: holtek,ht16k33.yaml: Add holtek,refuse-primary-fb

On Wed, Mar 30, 2022 at 09:34:40AM +0200, David Jander wrote:
> Document the DT property that will cause the holtek auxdisplay driver to
> back off if it detects that it is the first driver to probe a framebuffer
> device.
>
> Signed-off-by: David Jander <[email protected]>
> ---
> .../devicetree/bindings/auxdisplay/holtek,ht16k33.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/auxdisplay/holtek,ht16k33.yaml b/Documentation/devicetree/bindings/auxdisplay/holtek,ht16k33.yaml
> index fc4873deb76f..4de32c3e26ce 100644
> --- a/Documentation/devicetree/bindings/auxdisplay/holtek,ht16k33.yaml
> +++ b/Documentation/devicetree/bindings/auxdisplay/holtek,ht16k33.yaml
> @@ -53,6 +53,9 @@ properties:
> $ref: /schemas/leds/common.yaml#
> unevaluatedProperties: false
>
> + holtek,refuse-primary-fb:
> + description: Refuse to claim the first framebuffer device

How is this specific to this device?

Rob