LinuxLists.cc - [PATCH] arm64: dts: ls1028a: sl28: use ocelot-8021q tagging by default

2022-03-31 04:56:14

Subject: [PATCH] arm64: dts: ls1028a: sl28: use ocelot-8021q tagging by default

Enable the ocelot-8021q tagger by default which supports ethernet flow
control.

The new default is set in the common board dtsi. The actual switch
node is enabled on a per board variant basis. Because of this we
set the new tagger default for both internal ports and a particular
variant is free to choose among the two port.

Signed-off-by: Michael Walle <[email protected]>
---
.../arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
index 7ef47b80e343..68d11a9c67f3 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
@@ -328,6 +328,14 @@ &lpuart1 {
status = "okay";
};

+&mscc_felix_port4 {
+ dsa-tag-protocol = "ocelot-8021q";
+};
+
+&mscc_felix_port5 {
+ dsa-tag-protocol = "ocelot-8021q";
+};
+
&usb0 {
status = "okay";
};
--
2.30.2

2022-04-01 14:53:02

by Vladimir Oltean

[permalink] [raw]

Subject: Re: [PATCH] arm64: dts: ls1028a: sl28: use ocelot-8021q tagging by default

On Wed, Mar 30, 2022 at 01:33:29PM +0200, Michael Walle wrote:
> Enable the ocelot-8021q tagger by default which supports ethernet flow
> control.
>
> The new default is set in the common board dtsi. The actual switch
> node is enabled on a per board variant basis. Because of this we
> set the new tagger default for both internal ports and a particular
> variant is free to choose among the two port.
>
> Signed-off-by: Michael Walle <[email protected]>
> ---

Reviewed-by: Vladimir Oltean <[email protected]>

> .../arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> index 7ef47b80e343..68d11a9c67f3 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28.dts
> @@ -328,6 +328,14 @@ &lpuart1 {
> status = "okay";
> };
>
> +&mscc_felix_port4 {
> + dsa-tag-protocol = "ocelot-8021q";
> +};
> +
> +&mscc_felix_port5 {
> + dsa-tag-protocol = "ocelot-8021q";
> +};
> +
> &usb0 {
> status = "okay";
> };
> --
> 2.30.2
>

2022-04-11 17:21:12

by Shawn Guo

[permalink] [raw]