2022-04-02 15:01:20

by Xiaomeng Tong

Subject: [PATCH] drm/gma500: fix a missing break in psb_intel_crtc_mode_set

Instead of exiting the loop as expected when an entry is found, the
list_for_each_entry() continues until the traversal is complete.
when found the entry, add a break after the switch statement.

Signed-off-by: Xiaomeng Tong <[email protected]>
---
drivers/gpu/drm/gma500/psb_intel_display.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/gma500/psb_intel_display.c b/drivers/gpu/drm/gma500/psb_intel_display.c
index dc467996cce4..9a5ea06a1a8e 100644
--- a/drivers/gpu/drm/gma500/psb_intel_display.c
+++ b/drivers/gpu/drm/gma500/psb_intel_display.c
@@ -135,6 +135,8 @@ static int psb_intel_crtc_mode_set(struct drm_crtc *crtc,
is_tv = true;
break;
}
+
+ break;
}
drm_connector_list_iter_end(&conn_iter);

--
2.17.1

2022-04-06 14:25:34

by Patrik Jakobsson

Subject: Re: [PATCH] drm/gma500: fix a missing break in psb_intel_crtc_mode_set

On Fri, Apr 1, 2022 at 1:50 PM Xiaomeng Tong <[email protected]> wrote:
>
> Instead of exiting the loop as expected when an entry is found, the
> list_for_each_entry() continues until the traversal is complete.
> when found the entry, add a break after the switch statement.
>
> Signed-off-by: Xiaomeng Tong <[email protected]>

Thanks for the patch
Applied to drm-misc-next

> ---
> drivers/gpu/drm/gma500/psb_intel_display.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/gma500/psb_intel_display.c b/drivers/gpu/drm/gma500/psb_intel_display.c
> index dc467996cce4..9a5ea06a1a8e 100644
> --- a/drivers/gpu/drm/gma500/psb_intel_display.c
> +++ b/drivers/gpu/drm/gma500/psb_intel_display.c
> @@ -135,6 +135,8 @@ static int psb_intel_crtc_mode_set(struct drm_crtc *crtc,
> is_tv = true;
> break;
> }
> +
> + break;
> }
> drm_connector_list_iter_end(&conn_iter);
>
> --
> 2.17.1
>