2022-04-05 01:56:50

by Denis Pauk

Subject: [PATCH v2] hwmon: (asus_wmi_sensors) Fix CROSSHAIR VI HERO name

CROSSHAIR VI HERO motherboard is incorrectly named as
ROG CROSSHAIR VI HERO. Issue is found by github user in [1].

[1]: https://github.com/electrified/asus-wmi-sensors/pull/79

Signed-off-by: Denis Pauk <[email protected]>

---
Changes in v2:
- fix base commit.
---
drivers/hwmon/asus_wmi_sensors.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwmon/asus_wmi_sensors.c b/drivers/hwmon/asus_wmi_sensors.c
index c80eee874b6c..49784a6ea23a 100644
--- a/drivers/hwmon/asus_wmi_sensors.c
+++ b/drivers/hwmon/asus_wmi_sensors.c
@@ -71,7 +71,7 @@ static const struct dmi_system_id asus_wmi_dmi_table[] = {
DMI_EXACT_MATCH_ASUS_BOARD_NAME("PRIME X399-A"),
DMI_EXACT_MATCH_ASUS_BOARD_NAME("PRIME X470-PRO"),
DMI_EXACT_MATCH_ASUS_BOARD_NAME("ROG CROSSHAIR VI EXTREME"),
- DMI_EXACT_MATCH_ASUS_BOARD_NAME("ROG CROSSHAIR VI HERO"),
+ DMI_EXACT_MATCH_ASUS_BOARD_NAME("CROSSHAIR VI HERO"),
DMI_EXACT_MATCH_ASUS_BOARD_NAME("ROG CROSSHAIR VI HERO (WI-FI AC)"),
DMI_EXACT_MATCH_ASUS_BOARD_NAME("ROG CROSSHAIR VII HERO"),
DMI_EXACT_MATCH_ASUS_BOARD_NAME("ROG CROSSHAIR VII HERO (WI-FI)"),

base-commit: f443e374ae131c168a065ea1748feac6b2e76613
--
2.35.1

2022-04-05 02:32:20

by Guenter Roeck

Subject: Re: [PATCH v2] hwmon: (asus_wmi_sensors) Fix CROSSHAIR VI HERO name

On 4/3/22 12:34, Denis Pauk wrote:
> CROSSHAIR VI HERO motherboard is incorrectly named as
> ROG CROSSHAIR VI HERO. Issue is found by github user in [1].
>
> [1]: https://github.com/electrified/asus-wmi-sensors/pull/79
>

We have an official Reported-by: tag to give credit to reporters.
I don't see value in deviating from that. I can understand
if a reporter wants to remain anonymous, but then a link
to the anonymous report is pointless.

> Signed-off-by: Denis Pauk <[email protected]>
>
> ---
> Changes in v2:
> - fix base commit.

That would not be a reason to send v2. Did this otherwise cause a conflict,
or is there some other problem with v1 ? If so, please provide such
information in the change log. I tried to apply v1 on top of mainline,
though, and it didn't report a conflict for me, so I am a bit confused.

Thanks,
Guenter

> ---
> drivers/hwmon/asus_wmi_sensors.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/asus_wmi_sensors.c b/drivers/hwmon/asus_wmi_sensors.c
> index c80eee874b6c..49784a6ea23a 100644
> --- a/drivers/hwmon/asus_wmi_sensors.c
> +++ b/drivers/hwmon/asus_wmi_sensors.c
> @@ -71,7 +71,7 @@ static const struct dmi_system_id asus_wmi_dmi_table[] = {
> DMI_EXACT_MATCH_ASUS_BOARD_NAME("PRIME X399-A"),
> DMI_EXACT_MATCH_ASUS_BOARD_NAME("PRIME X470-PRO"),
> DMI_EXACT_MATCH_ASUS_BOARD_NAME("ROG CROSSHAIR VI EXTREME"),
> - DMI_EXACT_MATCH_ASUS_BOARD_NAME("ROG CROSSHAIR VI HERO"),
> + DMI_EXACT_MATCH_ASUS_BOARD_NAME("CROSSHAIR VI HERO"),
> DMI_EXACT_MATCH_ASUS_BOARD_NAME("ROG CROSSHAIR VI HERO (WI-FI AC)"),
> DMI_EXACT_MATCH_ASUS_BOARD_NAME("ROG CROSSHAIR VII HERO"),
> DMI_EXACT_MATCH_ASUS_BOARD_NAME("ROG CROSSHAIR VII HERO (WI-FI)"),
>
> base-commit: f443e374ae131c168a065ea1748feac6b2e76613