2022-04-06 11:12:10

by Tim Harvey

Subject: [PATCH v2] ARM: dts: imx8mm-venice-gw{71xx,72xx,73xx}: fix OTG controller OC mode

The GW71xx, GW72xx and GW73xx boards have USB1 routed to a USB OTG
connectors and USB2 routed to a USB hub.

The OTG connector has a over-currently protection with an active-low
pin and the USB1 to HUB connection has no over-current protection (as
the HUB itself implements this for its downstream ports).

Add proper dt nodes to specify the over-current pin polarity for USB1
and disable over-current protection for USB2.

Fixes: 6f30b27c5ef5 ("arm64: dts: imx8mm: Add Gateworks i.MX 8M Mini Development Kits")
Cc: [email protected]
Signed-off-by: Tim Harvey <[email protected]>
---
v2: add gw71xx as well
---
arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx.dtsi | 2 ++
arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi | 2 ++
arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi | 2 ++
3 files changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx.dtsi
index 73addc0b8e57..6671b99177e5 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx.dtsi
@@ -146,12 +146,14 @@

&usbotg1 {
dr_mode = "otg";
+ over-current-active-low;
vbus-supply = <&reg_usb_otg1_vbus>;
status = "okay";
};

&usbotg2 {
dr_mode = "host";
+ disable-over-current;
status = "okay";
};

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi
index 1e7badb2a82e..b6b3578a0f89 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi
@@ -211,12 +211,14 @@

&usbotg1 {
dr_mode = "otg";
+ over-current-active-low;
vbus-supply = <&reg_usb_otg1_vbus>;
status = "okay";
};

&usbotg2 {
dr_mode = "host";
+ disable-over-current;
vbus-supply = <&reg_usb_otg2_vbus>;
status = "okay";
};
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi
index 7a5d45e80982..89fc2c595056 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi
@@ -239,12 +239,14 @@

&usbotg1 {
dr_mode = "otg";
+ over-current-active-low;
vbus-supply = <&reg_usb_otg1_vbus>;
status = "okay";
};

&usbotg2 {
dr_mode = "host";
+ disable-over-current;
vbus-supply = <&reg_usb_otg2_vbus>;
status = "okay";
};
--
2.17.1

2022-04-11 12:49:03

by Shawn Guo

Subject: Re: [PATCH v2] ARM: dts: imx8mm-venice-gw{71xx,72xx,73xx}: fix OTG controller OC mode

On Tue, Apr 05, 2022 at 12:35:09PM -0700, Tim Harvey wrote:
> The GW71xx, GW72xx and GW73xx boards have USB1 routed to a USB OTG
> connectors and USB2 routed to a USB hub.
>
> The OTG connector has a over-currently protection with an active-low
> pin and the USB1 to HUB connection has no over-current protection (as
> the HUB itself implements this for its downstream ports).
>
> Add proper dt nodes to specify the over-current pin polarity for USB1
> and disable over-current protection for USB2.
>
> Fixes: 6f30b27c5ef5 ("arm64: dts: imx8mm: Add Gateworks i.MX 8M Mini Development Kits")
> Cc: [email protected]
> Signed-off-by: Tim Harvey <[email protected]>
> ---
> v2: add gw71xx as well

Okay, applied v2 instead.