2022-04-06 12:56:03

by Felix Fietkau

[permalink] [raw]
Subject: [PATCH v2 01/14] dt-bindings: net: mediatek: add optional properties for the SoC ethernet core

From: Lorenzo Bianconi <[email protected]>

Introduce dma-coherent, cci-control and hifsys optional properties to
the mediatek ethernet controller bindings

Signed-off-by: Lorenzo Bianconi <[email protected]>
Signed-off-by: Felix Fietkau <[email protected]>
---
Documentation/devicetree/bindings/net/mediatek-net.txt | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/mediatek-net.txt b/Documentation/devicetree/bindings/net/mediatek-net.txt
index 72d03e07cf7c..13cb12ee4ed6 100644
--- a/Documentation/devicetree/bindings/net/mediatek-net.txt
+++ b/Documentation/devicetree/bindings/net/mediatek-net.txt
@@ -41,6 +41,12 @@ Required properties:
- mediatek,pctl: phandle to the syscon node that handles the ports slew rate
and driver current: only for MT2701 and MT7623 SoC

+Optional properties:
+- dma-coherent: present if dma operations are coherent
+- mediatek,cci-control: phandle to the cache coherent interconnect node
+- mediatek,hifsys: phandle to the mediatek hifsys controller used to provide
+ various clocks and reset to the system.
+
* Ethernet MAC node

Required properties:
--
2.35.1


2022-04-07 20:38:53

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v2 01/14] dt-bindings: net: mediatek: add optional properties for the SoC ethernet core

On Tue, Apr 05, 2022 at 09:57:42PM +0200, Felix Fietkau wrote:
> From: Lorenzo Bianconi <[email protected]>
>
> Introduce dma-coherent, cci-control and hifsys optional properties to
> the mediatek ethernet controller bindings
>
> Signed-off-by: Lorenzo Bianconi <[email protected]>
> Signed-off-by: Felix Fietkau <[email protected]>
> ---
> Documentation/devicetree/bindings/net/mediatek-net.txt | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/mediatek-net.txt b/Documentation/devicetree/bindings/net/mediatek-net.txt
> index 72d03e07cf7c..13cb12ee4ed6 100644
> --- a/Documentation/devicetree/bindings/net/mediatek-net.txt
> +++ b/Documentation/devicetree/bindings/net/mediatek-net.txt
> @@ -41,6 +41,12 @@ Required properties:
> - mediatek,pctl: phandle to the syscon node that handles the ports slew rate
> and driver current: only for MT2701 and MT7623 SoC
>
> +Optional properties:
> +- dma-coherent: present if dma operations are coherent
> +- mediatek,cci-control: phandle to the cache coherent interconnect node

There's a common property for this already. See CCI-400 binding.

> +- mediatek,hifsys: phandle to the mediatek hifsys controller used to provide
> + various clocks and reset to the system.
> +

This series is adding a handful of new properties. Please convert the
binding to DT schema first.

Rob

2022-04-08 10:34:27

by Lorenzo Bianconi

[permalink] [raw]
Subject: Re: [PATCH v2 01/14] dt-bindings: net: mediatek: add optional properties for the SoC ethernet core

> On Tue, Apr 05, 2022 at 09:57:42PM +0200, Felix Fietkau wrote:
> > From: Lorenzo Bianconi <[email protected]>
> >
> > Introduce dma-coherent, cci-control and hifsys optional properties to
> > the mediatek ethernet controller bindings
> >
> > Signed-off-by: Lorenzo Bianconi <[email protected]>
> > Signed-off-by: Felix Fietkau <[email protected]>
> > ---
> > Documentation/devicetree/bindings/net/mediatek-net.txt | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/mediatek-net.txt b/Documentation/devicetree/bindings/net/mediatek-net.txt
> > index 72d03e07cf7c..13cb12ee4ed6 100644
> > --- a/Documentation/devicetree/bindings/net/mediatek-net.txt
> > +++ b/Documentation/devicetree/bindings/net/mediatek-net.txt
> > @@ -41,6 +41,12 @@ Required properties:
> > - mediatek,pctl: phandle to the syscon node that handles the ports slew rate
> > and driver current: only for MT2701 and MT7623 SoC
> >
> > +Optional properties:
> > +- dma-coherent: present if dma operations are coherent
> > +- mediatek,cci-control: phandle to the cache coherent interconnect node
>
> There's a common property for this already. See CCI-400 binding.
>
> > +- mediatek,hifsys: phandle to the mediatek hifsys controller used to provide
> > + various clocks and reset to the system.
> > +
>
> This series is adding a handful of new properties. Please convert the
> binding to DT schema first.

ack, I will converti this file to yaml format.

Regards,
Lorenzo

>
> Rob


Attachments:
(No filename) (1.52 kB)
signature.asc (235.00 B)
Download all attachments