2022-04-06 14:30:38

by Prabhakar Mahadev Lad

[permalink] [raw]
Subject: [PATCH] iio: adc: Kconfig: Make RZG2L_ADC depend on ARCH_RZG2L

ADC block is common on Renesas RZ/G2L and RZ/V2L SoC's, so instead of
adding dependency for each SoC's add dependency on ARCH_RZG2L. The
ARCH_RZG2L config option is already selected by ARCH_R9A07G044 and
ARCH_R9A07G054.

Signed-off-by: Lad Prabhakar <[email protected]>
---
drivers/iio/adc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index 71ab0a06aa82..48ace7412874 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -910,7 +910,7 @@ config ROCKCHIP_SARADC

config RZG2L_ADC
tristate "Renesas RZ/G2L ADC driver"
- depends on ARCH_R9A07G044 || COMPILE_TEST
+ depends on ARCH_RZG2L || COMPILE_TEST
help
Say yes here to build support for the ADC found in Renesas
RZ/G2L family.
--
2.17.1


2022-04-12 04:29:53

by Jonathan Cameron

[permalink] [raw]
Subject: Re: [PATCH] iio: adc: Kconfig: Make RZG2L_ADC depend on ARCH_RZG2L

On Wed, 6 Apr 2022 08:03:15 +0100
Lad Prabhakar <[email protected]> wrote:

> ADC block is common on Renesas RZ/G2L and RZ/V2L SoC's, so instead of
> adding dependency for each SoC's add dependency on ARCH_RZG2L. The
> ARCH_RZG2L config option is already selected by ARCH_R9A07G044 and
> ARCH_R9A07G054.
>
> Signed-off-by: Lad Prabhakar <[email protected]>
Sounds like a fix?

If so, please supply a Fixes tag.
no need to resend, just reply with one to this email.

thanks,

Jonathan

> ---
> drivers/iio/adc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index 71ab0a06aa82..48ace7412874 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -910,7 +910,7 @@ config ROCKCHIP_SARADC
>
> config RZG2L_ADC
> tristate "Renesas RZ/G2L ADC driver"
> - depends on ARCH_R9A07G044 || COMPILE_TEST
> + depends on ARCH_RZG2L || COMPILE_TEST
> help
> Say yes here to build support for the ADC found in Renesas
> RZ/G2L family.

2022-04-12 10:05:16

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH] iio: adc: Kconfig: Make RZG2L_ADC depend on ARCH_RZG2L

Hi Jonathan,

On Sun, Apr 10, 2022 at 7:52 PM Jonathan Cameron <[email protected]> wrote:
> On Wed, 6 Apr 2022 08:03:15 +0100
> Lad Prabhakar <[email protected]> wrote:
>
> > ADC block is common on Renesas RZ/G2L and RZ/V2L SoC's, so instead of
> > adding dependency for each SoC's add dependency on ARCH_RZG2L. The
> > ARCH_RZG2L config option is already selected by ARCH_R9A07G044 and
> > ARCH_R9A07G054.
> >
> > Signed-off-by: Lad Prabhakar <[email protected]>

Reviewed-by: Geert Uytterhoeven <[email protected]>

> Sounds like a fix?
>
> If so, please supply a Fixes tag.
> no need to resend, just reply with one to this email.

This is not really a fix, as the original dependency was correct at
that time.
This is a change to add support for the RZ/V2L (r9a07g054) SoC, and
avoiding the need to update the dependencies when support is added
for more SoCs of the RZ/G2L family later.

> > --- a/drivers/iio/adc/Kconfig
> > +++ b/drivers/iio/adc/Kconfig
> > @@ -910,7 +910,7 @@ config ROCKCHIP_SARADC
> >
> > config RZG2L_ADC
> > tristate "Renesas RZ/G2L ADC driver"
> > - depends on ARCH_R9A07G044 || COMPILE_TEST
> > + depends on ARCH_RZG2L || COMPILE_TEST
> > help
> > Say yes here to build support for the ADC found in Renesas
> > RZ/G2L family.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2022-04-18 01:13:07

by Jonathan Cameron

[permalink] [raw]
Subject: Re: [PATCH] iio: adc: Kconfig: Make RZG2L_ADC depend on ARCH_RZG2L

On Mon, 11 Apr 2022 16:40:20 +0200
Geert Uytterhoeven <[email protected]> wrote:

> Hi Jonathan,
>
> On Sun, Apr 10, 2022 at 7:52 PM Jonathan Cameron <[email protected]> wrote:
> > On Wed, 6 Apr 2022 08:03:15 +0100
> > Lad Prabhakar <[email protected]> wrote:
> >
> > > ADC block is common on Renesas RZ/G2L and RZ/V2L SoC's, so instead of
> > > adding dependency for each SoC's add dependency on ARCH_RZG2L. The
> > > ARCH_RZG2L config option is already selected by ARCH_R9A07G044 and
> > > ARCH_R9A07G054.
> > >
> > > Signed-off-by: Lad Prabhakar <[email protected]>
>
> Reviewed-by: Geert Uytterhoeven <[email protected]>
Applied. Thanks,

Jonathan

>
> > Sounds like a fix?
> >
> > If so, please supply a Fixes tag.
> > no need to resend, just reply with one to this email.
>
> This is not really a fix, as the original dependency was correct at
> that time.
> This is a change to add support for the RZ/V2L (r9a07g054) SoC, and
> avoiding the need to update the dependencies when support is added
> for more SoCs of the RZ/G2L family later.
>
> > > --- a/drivers/iio/adc/Kconfig
> > > +++ b/drivers/iio/adc/Kconfig
> > > @@ -910,7 +910,7 @@ config ROCKCHIP_SARADC
> > >
> > > config RZG2L_ADC
> > > tristate "Renesas RZ/G2L ADC driver"
> > > - depends on ARCH_R9A07G044 || COMPILE_TEST
> > > + depends on ARCH_RZG2L || COMPILE_TEST
> > > help
> > > Say yes here to build support for the ADC found in Renesas
> > > RZ/G2L family.
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds