2022-02-16 08:12:16

by Oleksij Rempel

[permalink] [raw]
Subject: [PATCH v5 9/9] arm64: dts: imx8mm-kontron: fix ethernet node name

The node name of Ethernet controller should be "ethernet" instead of
"usbether" as required by Ethernet controller devicetree schema:
Documentation/devicetree/bindings/net/ethernet-controller.yaml

This patch can potentially affect boot loaders patching against full
node path instead of using device aliases.

Signed-off-by: Oleksij Rempel <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts
index d40caf14ac4a..23be1ec538ba 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts
@@ -182,7 +182,7 @@ usb1@1 {
#address-cells = <1>;
#size-cells = <0>;

- usbnet: usbether@1 {
+ usbnet: ethernet@1 {
compatible = "usb424,ec00";
reg = <1>;
local-mac-address = [ 00 00 00 00 00 00 ];
--
2.30.2


2022-04-06 14:14:48

by Frieder Schrempf

[permalink] [raw]
Subject: Re: [PATCH v5 9/9] arm64: dts: imx8mm-kontron: fix ethernet node name

Am 06.04.22 um 03:13 schrieb Shawn Guo:
> + Frieder Schrempf who is the board owner.
>
> On Wed, Feb 16, 2022 at 08:49:27AM +0100, Oleksij Rempel wrote:
>> The node name of Ethernet controller should be "ethernet" instead of
>> "usbether" as required by Ethernet controller devicetree schema:
>> Documentation/devicetree/bindings/net/ethernet-controller.yaml
>>
>> This patch can potentially affect boot loaders patching against full
>> node path instead of using device aliases.
>
> Frieder,
>
> Are you okay with that?

Yes!

>
> Shawn
>
>>
>> Signed-off-by: Oleksij Rempel <[email protected]>

Acked-by: Frieder Schrempf <[email protected]>

>> ---
>> arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts
>> index d40caf14ac4a..23be1ec538ba 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts
>> +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts
>> @@ -182,7 +182,7 @@ usb1@1 {
>> #address-cells = <1>;
>> #size-cells = <0>;
>>
>> - usbnet: usbether@1 {
>> + usbnet: ethernet@1 {
>> compatible = "usb424,ec00";
>> reg = <1>;
>> local-mac-address = [ 00 00 00 00 00 00 ];
>> --
>> 2.30.2
>>

2022-04-06 15:23:30

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCH v5 9/9] arm64: dts: imx8mm-kontron: fix ethernet node name

+ Frieder Schrempf who is the board owner.

On Wed, Feb 16, 2022 at 08:49:27AM +0100, Oleksij Rempel wrote:
> The node name of Ethernet controller should be "ethernet" instead of
> "usbether" as required by Ethernet controller devicetree schema:
> Documentation/devicetree/bindings/net/ethernet-controller.yaml
>
> This patch can potentially affect boot loaders patching against full
> node path instead of using device aliases.

Frieder,

Are you okay with that?

Shawn

>
> Signed-off-by: Oleksij Rempel <[email protected]>
> ---
> arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts
> index d40caf14ac4a..23be1ec538ba 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts
> @@ -182,7 +182,7 @@ usb1@1 {
> #address-cells = <1>;
> #size-cells = <0>;
>
> - usbnet: usbether@1 {
> + usbnet: ethernet@1 {
> compatible = "usb424,ec00";
> reg = <1>;
> local-mac-address = [ 00 00 00 00 00 00 ];
> --
> 2.30.2
>

2022-04-06 16:26:18

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCH v5 9/9] arm64: dts: imx8mm-kontron: fix ethernet node name

On Wed, Feb 16, 2022 at 08:49:27AM +0100, Oleksij Rempel wrote:
> The node name of Ethernet controller should be "ethernet" instead of
> "usbether" as required by Ethernet controller devicetree schema:
> Documentation/devicetree/bindings/net/ethernet-controller.yaml
>
> This patch can potentially affect boot loaders patching against full
> node path instead of using device aliases.
>
> Signed-off-by: Oleksij Rempel <[email protected]>

Applied, thanks!