After conversion the jedec,spi-nor DT schema to reference other schemas
(SPI and MTD) and use unevaluatedProperties, several properties are
redundant.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../devicetree/bindings/mtd/jedec,spi-nor.yaml | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
index 4abfb4cfc157..708e7f88fd92 100644
--- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
+++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
@@ -50,10 +50,6 @@ properties:
minItems: 1
maxItems: 2
- spi-max-frequency: true
- spi-rx-bus-width: true
- spi-tx-bus-width: true
-
m25p,fast-read:
type: boolean
description:
@@ -74,14 +70,9 @@ properties:
be used on such systems, to denote the absence of a reliable reset
mechanism.
- label: true
-
partitions:
type: object
- '#address-cells': true
- '#size-cells': true
-
patternProperties:
# Note: use 'partitions' node for new users
'^partition@':
@@ -99,8 +90,6 @@ examples:
#size-cells = <0>;
flash@0 {
- #address-cells = <1>;
- #size-cells = <1>;
compatible = "spansion,m25p80", "jedec,spi-nor";
reg = <0>;
spi-max-frequency = <40000000>;
--
2.32.0
On Thu, Apr 07, 2022 at 04:20:04PM +0200, Krzysztof Kozlowski wrote:
> After conversion the jedec,spi-nor DT schema to reference other schemas
> (SPI and MTD) and use unevaluatedProperties, several properties are
> redundant.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../devicetree/bindings/mtd/jedec,spi-nor.yaml | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> index 4abfb4cfc157..708e7f88fd92 100644
> --- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> @@ -50,10 +50,6 @@ properties:
> minItems: 1
> maxItems: 2
>
> - spi-max-frequency: true
> - spi-rx-bus-width: true
> - spi-tx-bus-width: true
> -
> m25p,fast-read:
> type: boolean
> description:
> @@ -74,14 +70,9 @@ properties:
> be used on such systems, to denote the absence of a reliable reset
> mechanism.
>
> - label: true
> -
> partitions:
> type: object
>
> - '#address-cells': true
> - '#size-cells': true
These are needed for 'partition' nodes.
> -
> patternProperties:
> # Note: use 'partitions' node for new users
> '^partition@':
> @@ -99,8 +90,6 @@ examples:
> #size-cells = <0>;
>
> flash@0 {
> - #address-cells = <1>;
> - #size-cells = <1>;
> compatible = "spansion,m25p80", "jedec,spi-nor";
> reg = <0>;
> spi-max-frequency = <40000000>;
> --
> 2.32.0
>
>
On 07/04/22 04:20PM, Krzysztof Kozlowski wrote:
> After conversion the jedec,spi-nor DT schema to reference other schemas
> (SPI and MTD) and use unevaluatedProperties, several properties are
> redundant.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Pratyush Yadav <[email protected]>
--
Regards,
Pratyush Yadav
Texas Instruments Inc.
On 07/04/2022 20:21, Rob Herring wrote:
> On Thu, Apr 07, 2022 at 04:20:04PM +0200, Krzysztof Kozlowski wrote:
>> After conversion the jedec,spi-nor DT schema to reference other schemas
>> (SPI and MTD) and use unevaluatedProperties, several properties are
>> redundant.
>>
>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>> ---
>> .../devicetree/bindings/mtd/jedec,spi-nor.yaml | 11 -----------
>> 1 file changed, 11 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
>> index 4abfb4cfc157..708e7f88fd92 100644
>> --- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
>> +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
>> @@ -50,10 +50,6 @@ properties:
>> minItems: 1
>> maxItems: 2
>>
>> - spi-max-frequency: true
>> - spi-rx-bus-width: true
>> - spi-tx-bus-width: true
>> -
>> m25p,fast-read:
>> type: boolean
>> description:
>> @@ -74,14 +70,9 @@ properties:
>> be used on such systems, to denote the absence of a reliable reset
>> mechanism.
>>
>> - label: true
>> -
>> partitions:
>> type: object
>>
>> - '#address-cells': true
>> - '#size-cells': true
>
> These are needed for 'partition' nodes.
>
I am sure I saw them in one of referenced schemas, that's why I removed
them. But now I cannot find it so probably I looked at wrong schema.
Thanks for pointing this out, I'll fix the patch.
Best regards,
Krzysztof