2022-04-07 22:13:16

by Nícolas F. R. A. Prado

[permalink] [raw]
Subject: Re: [v9 3/4] ASoC: mediatek: mt8192: refactor for I2S8/I2S9 DAI links of headset

Hi Jiaxin,

On Wed, Apr 06, 2022 at 06:05:13PM +0800, Jiaxin Yu wrote:
> MT8192 platform use rt5682 codec, so through the snd_soc_of_get_dai_link_codecs()
> to complete the configuration of I2S8/I2S9 dai_link's codecs.

Likewise, suggestion for the commit message:

As part of the refactoring to allow the same machine driver to be used for the
rt1015(p) and rt5682(s) codecs on the MT8192 platform, parse the rt5682(s) codec
from the headset-codec property in the devicetree and wire it to the I2S8 and
I2S9 backends.

>
> Signed-off-by: Jiaxin Yu <[email protected]>
> Reviewed-by: Tzung-Bi Shih <[email protected]>

Reviewed-by: N?colas F. R. A. Prado <[email protected]>
Tested-by: N?colas F. R. A. Prado <[email protected]>

Thanks,
N?colas