2022-04-08 08:33:30

by Paran Lee

[permalink] [raw]
Subject: [PATCH] genirq: Refactor actions_show loop block using a common macro to go through the actions list

Since we have a macro defined in our IRQ subsystem internal functions to traverse the list of actions, how about refactoring this loop?
- genirq: Use a common macro to go through the actions list (f944b5a7aff05a244a6c8cac297819af09a199e4)

Signed-off-by: Paran Lee <[email protected]>
---
kernel/irq/irqdesc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/irq/irqdesc.c b/kernel/irq/irqdesc.c
index 939d21cd55c3..34a0cefff712 100644
--- a/kernel/irq/irqdesc.c
+++ b/kernel/irq/irqdesc.c
@@ -246,12 +246,12 @@ static ssize_t actions_show(struct kobject *kobj,
struct kobj_attribute *attr, char *buf)
{
struct irq_desc *desc = container_of(kobj, struct irq_desc, kobj);
- struct irqaction *action;
+ struct irqaction *action = NULL;
ssize_t ret = 0;
char *p = "";

raw_spin_lock_irq(&desc->lock);
- for (action = desc->action; action != NULL; action = action->next) {
+ for_each_action_of_desc(desc, action) {
ret += scnprintf(buf + ret, PAGE_SIZE - ret, "%s%s",
p, action->name);
p = ",";
--
2.25.1