2022-04-07 17:44:51

by David Hildenbrand

[permalink] [raw]
Subject: Re: [PATCH] mm, page_alloc: fix build_zonerefs_node()

On 07.04.22 11:32, Juergen Gross wrote:
> Since commit 9d3be21bf9c0 ("mm, page_alloc: simplify zonelist
> initialization") only zones with free memory are included in a built
> zonelist. This is problematic when e.g. all memory of a zone has been
> ballooned out.
>
> Use populated_zone() when building a zonelist as it has been done
> before that commit.
>
> Cc: [email protected]
> Fixes: 9d3be21bf9c0 ("mm, page_alloc: simplify zonelist initialization")
> Reported-by: Marek Marczykowski-Górecki <[email protected]>
> Signed-off-by: Juergen Gross <[email protected]>
> ---
> mm/page_alloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index bdc8f60ae462..3d0662af3289 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -6128,7 +6128,7 @@ static int build_zonerefs_node(pg_data_t *pgdat, struct zoneref *zonerefs)
> do {
> zone_type--;
> zone = pgdat->node_zones + zone_type;
> - if (managed_zone(zone)) {
> + if (populated_zone(zone)) {
> zoneref_set_zone(zone, &zonerefs[nr_zones++]);
> check_highest_zone(zone_type);
> }

Let's see if we have to find another way to properly handle fadump.

Acked-by: David Hildenbrand <[email protected]>

--
Thanks,

David / dhildenb


2022-04-11 19:04:44

by Wei Yang

[permalink] [raw]
Subject: Re: [PATCH] mm, page_alloc: fix build_zonerefs_node()

On Thu, Apr 07, 2022 at 11:46:13AM +0200, David Hildenbrand wrote:
>On 07.04.22 11:32, Juergen Gross wrote:
>> Since commit 9d3be21bf9c0 ("mm, page_alloc: simplify zonelist
>> initialization") only zones with free memory are included in a built
>> zonelist. This is problematic when e.g. all memory of a zone has been
>> ballooned out.
>>
>> Use populated_zone() when building a zonelist as it has been done
>> before that commit.
>>
>> Cc: [email protected]
>> Fixes: 9d3be21bf9c0 ("mm, page_alloc: simplify zonelist initialization")
>> Reported-by: Marek Marczykowski-G??recki <[email protected]>
>> Signed-off-by: Juergen Gross <[email protected]>
>> ---
>> mm/page_alloc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
>> index bdc8f60ae462..3d0662af3289 100644
>> --- a/mm/page_alloc.c
>> +++ b/mm/page_alloc.c
>> @@ -6128,7 +6128,7 @@ static int build_zonerefs_node(pg_data_t *pgdat, struct zoneref *zonerefs)
>> do {
>> zone_type--;
>> zone = pgdat->node_zones + zone_type;
>> - if (managed_zone(zone)) {
>> + if (populated_zone(zone)) {
>> zoneref_set_zone(zone, &zonerefs[nr_zones++]);
>> check_highest_zone(zone_type);
>> }
>
>Let's see if we have to find another way to properly handle fadump.
>
>Acked-by: David Hildenbrand <[email protected]>

Ok, I see the point.

Reviewed-by: Wei Yang <[email protected]>

>
>--
>Thanks,
>
>David / dhildenb

--
Wei Yang
Help you, Help me