2022-04-12 09:13:05

by Kuldeep Singh

[permalink] [raw]
Subject: [PATCH v2 1/6] ARM: dts: qcom: apq8064: User generic node name for DMA

Qcom BAM DT spec expects generic DMA controller node name as
"dma-controller" to enable validations.

Signed-off-by: Kuldeep Singh <[email protected]>
---
arch/arm/boot/dts/qcom-apq8064.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi
index a1c8ae516d21..b2975be3ae04 100644
--- a/arch/arm/boot/dts/qcom-apq8064.dtsi
+++ b/arch/arm/boot/dts/qcom-apq8064.dtsi
@@ -1040,7 +1040,7 @@ sata0: sata@29000000 {
};

/* Temporary fixed regulator */
- sdcc1bam:dma@12402000{
+ sdcc1bam: dma-controller@12402000{
compatible = "qcom,bam-v1.3.0";
reg = <0x12402000 0x8000>;
interrupts = <0 98 IRQ_TYPE_LEVEL_HIGH>;
@@ -1050,7 +1050,7 @@ sdcc1bam:dma@12402000{
qcom,ee = <0>;
};

- sdcc3bam:dma@12182000{
+ sdcc3bam: dma-controller@12182000{
compatible = "qcom,bam-v1.3.0";
reg = <0x12182000 0x8000>;
interrupts = <0 96 IRQ_TYPE_LEVEL_HIGH>;
@@ -1060,7 +1060,7 @@ sdcc3bam:dma@12182000{
qcom,ee = <0>;
};

- sdcc4bam:dma@121c2000{
+ sdcc4bam: dma-controller@121c2000{
compatible = "qcom,bam-v1.3.0";
reg = <0x121c2000 0x8000>;
interrupts = <0 95 IRQ_TYPE_LEVEL_HIGH>;
--
2.25.1


2022-04-12 20:42:57

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v2 1/6] ARM: dts: qcom: apq8064: User generic node name for DMA

On 10/04/2022 19:50, Kuldeep Singh wrote:
> Qcom BAM DT spec expects generic DMA controller node name as
> "dma-controller" to enable validations.
>
> Signed-off-by: Kuldeep Singh <[email protected]>
> ---
> arch/arm/boot/dts/qcom-apq8064.dtsi | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>

All arm changes could be one commit, it's a lot of churn for just name
renaming, but anyway:

Reviewed-by: Krzysztof Kozlowski <[email protected]>


Best regards,
Krzysztof

2022-04-12 22:51:21

by Kuldeep Singh

[permalink] [raw]
Subject: Re: [PATCH v2 1/6] ARM: dts: qcom: apq8064: User generic node name for DMA

On Sun, Apr 10, 2022 at 09:08:53PM +0200, Krzysztof Kozlowski wrote:
> On 10/04/2022 19:50, Kuldeep Singh wrote:
> > Qcom BAM DT spec expects generic DMA controller node name as
> > "dma-controller" to enable validations.
> >
> > Signed-off-by: Kuldeep Singh <[email protected]>
> > ---
> > arch/arm/boot/dts/qcom-apq8064.dtsi | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
>
> All arm changes could be one commit, it's a lot of churn for just name
> renaming, but anyway:

Ok. Since changes were in different file that's why i kept them
separate.

>
> Reviewed-by: Krzysztof Kozlowski <[email protected]>

Thanks!