2022-04-06 11:44:10

by Tim Harvey

Subject: [PATCH] imx8m{m,n}-venice-*: add missing uart-has-rtscts property to UARTs

Add the missing 'uart-has-rtscts' property to UART's that have hardware
flow control capability.

Signed-off-by: Tim Harvey <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi | 1 +
arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts | 3 +++
arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts | 3 +++
arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts | 1 +
4 files changed, 8 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi
index 426483ec1f88..7a5d45e80982 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi
@@ -221,6 +221,7 @@
pinctrl-0 = <&pinctrl_uart3>, <&pinctrl_bten>;
cts-gpios = <&gpio5 8 GPIO_ACTIVE_LOW>;
rts-gpios = <&gpio5 9 GPIO_ACTIVE_LOW>;
+ uart-has-rtscts;
status = "okay";

bluetooth {
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
index ee78c189c556..a23801deb4cd 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
@@ -716,6 +716,7 @@
dtr-gpios = <&gpio1 14 GPIO_ACTIVE_LOW>;
dsr-gpios = <&gpio1 1 GPIO_ACTIVE_LOW>;
dcd-gpios = <&gpio1 11 GPIO_ACTIVE_LOW>;
+ uart-has-rtscts;
status = "okay";
};

@@ -731,6 +732,7 @@
pinctrl-0 = <&pinctrl_uart3>;
cts-gpios = <&gpio4 10 GPIO_ACTIVE_LOW>;
rts-gpios = <&gpio4 9 GPIO_ACTIVE_LOW>;
+ uart-has-rtscts;
status = "okay";
};

@@ -739,6 +741,7 @@
pinctrl-0 = <&pinctrl_uart4>;
cts-gpios = <&gpio5 11 GPIO_ACTIVE_LOW>;
rts-gpios = <&gpio5 12 GPIO_ACTIVE_LOW>;
+ uart-has-rtscts;
status = "okay";
};

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts
index 49e15a671b67..6aa0eb463647 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts
@@ -644,6 +644,7 @@
pinctrl-0 = <&pinctrl_uart1>;
rts-gpios = <&gpio4 10 GPIO_ACTIVE_LOW>;
cts-gpios = <&gpio4 11 GPIO_ACTIVE_LOW>;
+ uart-has-rtscts;
status = "okay";
};

@@ -660,6 +661,7 @@
pinctrl-0 = <&pinctrl_uart3>, <&pinctrl_uart3_gpio>;
rts-gpios = <&gpio2 1 GPIO_ACTIVE_LOW>;
cts-gpios = <&gpio2 0 GPIO_ACTIVE_LOW>;
+ uart-has-rtscts;
status = "okay";

bluetooth {
@@ -677,6 +679,7 @@
dtr-gpios = <&gpio4 3 GPIO_ACTIVE_LOW>;
dsr-gpios = <&gpio4 4 GPIO_ACTIVE_LOW>;
dcd-gpios = <&gpio4 6 GPIO_ACTIVE_LOW>;
+ uart-has-rtscts;
status = "okay";
};

diff --git a/arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts b/arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts
index 3c0e63d2e82d..2c1f591335ad 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts
@@ -625,6 +625,7 @@
pinctrl-0 = <&pinctrl_uart3>, <&pinctrl_uart3_gpio>;
rts-gpios = <&gpio2 1 GPIO_ACTIVE_LOW>;
cts-gpios = <&gpio2 0 GPIO_ACTIVE_LOW>;
+ uart-has-rtscts;
status = "okay";

bluetooth {
--
2.17.1

2022-04-12 21:13:34

by Shawn Guo

Subject: Re: [PATCH] imx8m{m,n}-venice-*: add missing uart-has-rtscts property to UARTs

On Tue, Apr 05, 2022 at 01:02:23PM -0700, Tim Harvey wrote:
> Add the missing 'uart-has-rtscts' property to UART's that have hardware
> flow control capability.
>
> Signed-off-by: Tim Harvey <[email protected]>

'arm64: dts: ...' subject prefix please.

And it doesn't apply to imx/dt64 branch.

Shawn

> ---
> arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi | 1 +
> arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts | 3 +++
> arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts | 3 +++
> arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts | 1 +
> 4 files changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi
> index 426483ec1f88..7a5d45e80982 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi
> @@ -221,6 +221,7 @@
> pinctrl-0 = <&pinctrl_uart3>, <&pinctrl_bten>;
> cts-gpios = <&gpio5 8 GPIO_ACTIVE_LOW>;
> rts-gpios = <&gpio5 9 GPIO_ACTIVE_LOW>;
> + uart-has-rtscts;
> status = "okay";
>
> bluetooth {
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
> index ee78c189c556..a23801deb4cd 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
> @@ -716,6 +716,7 @@
> dtr-gpios = <&gpio1 14 GPIO_ACTIVE_LOW>;
> dsr-gpios = <&gpio1 1 GPIO_ACTIVE_LOW>;
> dcd-gpios = <&gpio1 11 GPIO_ACTIVE_LOW>;
> + uart-has-rtscts;
> status = "okay";
> };
>
> @@ -731,6 +732,7 @@
> pinctrl-0 = <&pinctrl_uart3>;
> cts-gpios = <&gpio4 10 GPIO_ACTIVE_LOW>;
> rts-gpios = <&gpio4 9 GPIO_ACTIVE_LOW>;
> + uart-has-rtscts;
> status = "okay";
> };
>
> @@ -739,6 +741,7 @@
> pinctrl-0 = <&pinctrl_uart4>;
> cts-gpios = <&gpio5 11 GPIO_ACTIVE_LOW>;
> rts-gpios = <&gpio5 12 GPIO_ACTIVE_LOW>;
> + uart-has-rtscts;
> status = "okay";
> };
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts
> index 49e15a671b67..6aa0eb463647 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts
> @@ -644,6 +644,7 @@
> pinctrl-0 = <&pinctrl_uart1>;
> rts-gpios = <&gpio4 10 GPIO_ACTIVE_LOW>;
> cts-gpios = <&gpio4 11 GPIO_ACTIVE_LOW>;
> + uart-has-rtscts;
> status = "okay";
> };
>
> @@ -660,6 +661,7 @@
> pinctrl-0 = <&pinctrl_uart3>, <&pinctrl_uart3_gpio>;
> rts-gpios = <&gpio2 1 GPIO_ACTIVE_LOW>;
> cts-gpios = <&gpio2 0 GPIO_ACTIVE_LOW>;
> + uart-has-rtscts;
> status = "okay";
>
> bluetooth {
> @@ -677,6 +679,7 @@
> dtr-gpios = <&gpio4 3 GPIO_ACTIVE_LOW>;
> dsr-gpios = <&gpio4 4 GPIO_ACTIVE_LOW>;
> dcd-gpios = <&gpio4 6 GPIO_ACTIVE_LOW>;
> + uart-has-rtscts;
> status = "okay";
> };
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts b/arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts
> index 3c0e63d2e82d..2c1f591335ad 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts
> @@ -625,6 +625,7 @@
> pinctrl-0 = <&pinctrl_uart3>, <&pinctrl_uart3_gpio>;
> rts-gpios = <&gpio2 1 GPIO_ACTIVE_LOW>;
> cts-gpios = <&gpio2 0 GPIO_ACTIVE_LOW>;
> + uart-has-rtscts;
> status = "okay";
>
> bluetooth {
> --
> 2.17.1
>