2022-04-12 11:42:42

by surong pang

Subject: [PATCH V1 1/1] usb/host: To get "usb3-slow-suspend" property, then to set xhci quirks

From: Surong Pang <[email protected]>

To set xhci->quirks value according to "usb3-slow-suspend" property

Signed-off-by: Surong Pang <[email protected]>
---
drivers/usb/host/xhci-plat.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
index 649ffd861b44..6bc456bc6468 100644
--- a/drivers/usb/host/xhci-plat.c
+++ b/drivers/usb/host/xhci-plat.c
@@ -302,6 +302,9 @@ static int xhci_plat_probe(struct platform_device *pdev)
if (device_property_read_bool(tmpdev, "usb3-lpm-capable"))
xhci->quirks |= XHCI_LPM_SUPPORT;

+ if (device_property_read_bool(tmpdev, "usb3-slow-suspend"))
+ xhci->quirks |= XHCI_SLOW_SUSPEND;
+
if (device_property_read_bool(tmpdev, "quirk-broken-port-ped"))
xhci->quirks |= XHCI_BROKEN_PORT_PED;

--
2.17.1

2022-04-12 22:49:02

by Greg Kroah-Hartman

Subject: Re: [PATCH V1 1/1] usb/host: To get "usb3-slow-suspend" property, then to set xhci quirks

On Tue, Apr 12, 2022 at 10:59:52AM +0800, Surong Pang wrote:
> From: Surong Pang <[email protected]>
>
> To set xhci->quirks value according to "usb3-slow-suspend" property
>
> Signed-off-by: Surong Pang <[email protected]>
> ---
> drivers/usb/host/xhci-plat.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> index 649ffd861b44..6bc456bc6468 100644
> --- a/drivers/usb/host/xhci-plat.c
> +++ b/drivers/usb/host/xhci-plat.c
> @@ -302,6 +302,9 @@ static int xhci_plat_probe(struct platform_device *pdev)
> if (device_property_read_bool(tmpdev, "usb3-lpm-capable"))
> xhci->quirks |= XHCI_LPM_SUPPORT;
>
> + if (device_property_read_bool(tmpdev, "usb3-slow-suspend"))
> + xhci->quirks |= XHCI_SLOW_SUSPEND;

Where is that property documented?

2022-04-22 18:00:42

by surong pang

Subject: Re: [PATCH V1 1/1] usb/host: To get "usb3-slow-suspend" property, then to set xhci quirks

We need to abandon this patch.

Greg KH <[email protected]> 于2022年4月22日周五 00:41写道：
>
> On Tue, Apr 12, 2022 at 10:59:52AM +0800, Surong Pang wrote:
> > From: Surong Pang <[email protected]>
> >
> > To set xhci->quirks value according to "usb3-slow-suspend" property
> >
> > Signed-off-by: Surong Pang <[email protected]>
> > ---
> > drivers/usb/host/xhci-plat.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> > index 649ffd861b44..6bc456bc6468 100644
> > --- a/drivers/usb/host/xhci-plat.c
> > +++ b/drivers/usb/host/xhci-plat.c
> > @@ -302,6 +302,9 @@ static int xhci_plat_probe(struct platform_device *pdev)
> > if (device_property_read_bool(tmpdev, "usb3-lpm-capable"))
> > xhci->quirks |= XHCI_LPM_SUPPORT;
> >
> > + if (device_property_read_bool(tmpdev, "usb3-slow-suspend"))
> > + xhci->quirks |= XHCI_SLOW_SUSPEND;
>
> Device properties need to be documented somewhere.
>

2022-04-22 20:19:18

by Greg Kroah-Hartman

Subject: Re: [PATCH V1 1/1] usb/host: To get "usb3-slow-suspend" property, then to set xhci quirks

On Tue, Apr 12, 2022 at 10:59:52AM +0800, Surong Pang wrote:
> From: Surong Pang <[email protected]>
>
> To set xhci->quirks value according to "usb3-slow-suspend" property
>
> Signed-off-by: Surong Pang <[email protected]>
> ---
> drivers/usb/host/xhci-plat.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> index 649ffd861b44..6bc456bc6468 100644
> --- a/drivers/usb/host/xhci-plat.c
> +++ b/drivers/usb/host/xhci-plat.c
> @@ -302,6 +302,9 @@ static int xhci_plat_probe(struct platform_device *pdev)
> if (device_property_read_bool(tmpdev, "usb3-lpm-capable"))
> xhci->quirks |= XHCI_LPM_SUPPORT;
>
> + if (device_property_read_bool(tmpdev, "usb3-slow-suspend"))
> + xhci->quirks |= XHCI_SLOW_SUSPEND;

Device properties need to be documented somewhere.