2022-04-12 21:47:19

by Ming Qian

Subject: [PATCH] media: amphion: fix decoder's interlaced filed

For interlaced frame, the amphion vpu will store the
two fileds sequential into one buffer, top-bottom order
so the filed should be set to V4L2_FIELD_SEQ_TB.
fix the previous bug that setting it to V4L2_FIELD_SEQ_BT wrongly.

Signed-off-by: Ming Qian <[email protected]>
---
drivers/media/platform/amphion/vdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/amphion/vdec.c b/drivers/media/platform/amphion/vdec.c
index 09628dd0c855..0a1976852b0d 100644
--- a/drivers/media/platform/amphion/vdec.c
+++ b/drivers/media/platform/amphion/vdec.c
@@ -804,7 +804,7 @@ static void vdec_init_fmt(struct vpu_inst *inst)
if (vdec->codec_info.progressive)
inst->cap_format.field = V4L2_FIELD_NONE;
else
- inst->cap_format.field = V4L2_FIELD_SEQ_BT;
+ inst->cap_format.field = V4L2_FIELD_SEQ_TB;
if (vdec->codec_info.color_primaries == V4L2_COLORSPACE_DEFAULT)
vdec->codec_info.color_primaries = V4L2_COLORSPACE_REC709;
if (vdec->codec_info.transfer_chars == V4L2_XFER_FUNC_DEFAULT)
--
2.35.1

2022-04-12 23:49:07

by Fabio Estevam

Subject: Re: [PATCH] media: amphion: fix decoder's interlaced filed

Hi Ming,

In Subject: s/filed/field

On Tue, Apr 12, 2022 at 7:52 AM Ming Qian <[email protected]> wrote:
>
> For interlaced frame, the amphion vpu will store the
> two fileds sequential into one buffer, top-bottom order

s/fileds/fields

> so the filed should be set to V4L2_FIELD_SEQ_TB.

s/filed/field

> fix the previous bug that setting it to V4L2_FIELD_SEQ_BT wrongly.

s/setting/set

Do you need to pass a Fixes tag too?