2022-04-13 09:14:07

by z

Subject: [PATCH] drm/tegra: remove useless if check before kfree

This patch remove useless if check before kfree.

Signed-off-by: Bernard Zhao <[email protected]>
---
drivers/gpu/drm/tegra/submit.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/tegra/submit.c b/drivers/gpu/drm/tegra/submit.c
index 6d6dd8c35475..54ac31bc80f6 100644
--- a/drivers/gpu/drm/tegra/submit.c
+++ b/drivers/gpu/drm/tegra/submit.c
@@ -639,8 +639,7 @@ int tegra_drm_ioctl_channel_submit(struct drm_device *drm, void *data,
kfree(job_data->used_mappings);
}

- if (job_data)
- kfree(job_data);
+ kfree(job_data);
put_bo:
gather_bo_put(&bo->base);
unlock:
--
2.33.1

2022-04-13 10:22:21

by Mikko Perttunen

Subject: Re: [PATCH] drm/tegra: remove useless if check before kfree

On 4/13/22 09:46, Bernard Zhao wrote:
> This patch remove useless if check before kfree.
>
> Signed-off-by: Bernard Zhao <[email protected]>
> ---
> drivers/gpu/drm/tegra/submit.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/tegra/submit.c b/drivers/gpu/drm/tegra/submit.c
> index 6d6dd8c35475..54ac31bc80f6 100644
> --- a/drivers/gpu/drm/tegra/submit.c
> +++ b/drivers/gpu/drm/tegra/submit.c
> @@ -639,8 +639,7 @@ int tegra_drm_ioctl_channel_submit(struct drm_device *drm, void *data,
> kfree(job_data->used_mappings);
> }
>
> - if (job_data)
> - kfree(job_data);
> + kfree(job_data);
> put_bo:
> gather_bo_put(&bo->base);
> unlock:

(Same comment as for other patch.)

I personally dislike leaving the NULL checks off with calls to kfree.
With the NULL check there, while reading the code it is obvious that the
intention is that the value can be either a valid pointer or NULL. IMHO
with C's type system/conventions we need this kind of contextual
information to understand the code easily and avoid bugs.

Mikko