2022-04-16 00:24:04

by Adrien Thierry

Subject: [PATCH v2 0/5] staging: bcm2835-audio: minor code style cleanups

This series contains minor code style cleanups to fix checkpatch warnings.

This handles TODO item "Fix the remaining checkpatch.pl errors and
warnings"

---

Changes since v1:
- removed mention of vc4 in Kconfig help text
- split patches so that each patch fixes only one checkpatch warning

Adrien Thierry (5):
staging: bcm2835-audio: fully describe config symbol
staging: bcm2835-audio: fix line ending with '('
staging: bcm2835-audio: fix unnecessary space after cast
staging: bcm2835-audio: fix mutex definition without comment
staging: bcm2835-audio: fix mutex definition without comment

drivers/staging/vc04_services/bcm2835-audio/Kconfig | 6 ++++--
drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 5 ++---
drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c | 2 +-
drivers/staging/vc04_services/bcm2835-audio/bcm2835.h | 2 +-
4 files changed, 8 insertions(+), 7 deletions(-)


base-commit: 194193dd06848c1839d928090cb2032eec8b2f9c
--
2.35.1

2022-04-16 01:53:59

by Adrien Thierry

Subject: [PATCH v2 1/5] staging: bcm2835-audio: fully describe config symbol

Explain SND_BCM2835 config option in more detail to fix checkpatch
warning:

WARNING: please write a help paragraph that fully describes the config
symbol
FILE: drivers/staging/vc04_services/bcm2835-audio/Kconfig:2

Signed-off-by: Adrien Thierry <[email protected]>
---
drivers/staging/vc04_services/bcm2835-audio/Kconfig | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/vc04_services/bcm2835-audio/Kconfig b/drivers/staging/vc04_services/bcm2835-audio/Kconfig
index d32ea348e846..307f2d6a9599 100644
--- a/drivers/staging/vc04_services/bcm2835-audio/Kconfig
+++ b/drivers/staging/vc04_services/bcm2835-audio/Kconfig
@@ -5,5 +5,7 @@ config SND_BCM2835
select SND_PCM
select BCM2835_VCHIQ
help
- Say Y or M if you want to support BCM2835 built in audio
-
+ Say Y or M if you want to support BCM2835 built in audio.
+ This driver handles both 3.5mm and HDMI audio, by leveraging
+ the VCHIQ messaging interface between the kernel and the firmware
+ running on VideoCore.
\ No newline at end of file
--
2.35.1

2022-04-16 02:10:31

by Adrien Thierry

Subject: [PATCH v2 2/5] staging: bcm2835-audio: fix line ending with '('

Fix issue reported by checkpatch:

CHECK: Lines should not end with a '('
FILE: drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c:85:

Signed-off-by: Adrien Thierry <[email protected]>
---
drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c
index f2ef1d641e70..856d3c022f80 100644
--- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c
+++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c
@@ -82,8 +82,7 @@ void bcm2835_playback_fifo(struct bcm2835_alsa_stream *alsa_stream,
}

/* open callback */
-static int snd_bcm2835_playback_open_generic(
- struct snd_pcm_substream *substream, int spdif)
+static int snd_bcm2835_playback_open_generic(struct snd_pcm_substream *substream, int spdif)
{
struct bcm2835_chip *chip = snd_pcm_substream_chip(substream);
struct snd_pcm_runtime *runtime = substream->runtime;
--
2.35.1