2022-04-16 02:40:47

by Jeff Daly

Subject: [PATCH] ixgbe: Fix module_param allow_unsupported_sfp type

The module_param allow_unsupported_sfp should be a boolean to match the
type in the ixgbe_hw struct.

Signed-off-by: Jeff Daly <[email protected]>
---
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
index c4a4954aa317..e5732a058bec 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
@@ -151,8 +151,8 @@ MODULE_PARM_DESC(max_vfs,
"Maximum number of virtual functions to allocate per physical function - default is zero and maximum value is 63. (Deprecated)");
#endif /* CONFIG_PCI_IOV */

-static unsigned int allow_unsupported_sfp;
-module_param(allow_unsupported_sfp, uint, 0);
+static bool allow_unsupported_sfp;
+module_param(allow_unsupported_sfp, bool, 0);
MODULE_PARM_DESC(allow_unsupported_sfp,
"Allow unsupported and untested SFP+ modules on 82599-based adapters");

--
2.25.1

2022-05-02 14:30:32

by G, GurucharanX

Subject: RE: [Intel-wired-lan] [PATCH] ixgbe: Fix module_param allow_unsupported_sfp type

> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf Of
> Jeff Daly
> Sent: Friday, April 15, 2022 1:51 AM
> To: [email protected]
> Cc: open list:NETWORKING DRIVERS <[email protected]>; open list
> <[email protected]>; moderated list:INTEL ETHERNET DRIVERS
> <[email protected]>; Jakub Kicinski <[email protected]>; Paolo
> Abeni <[email protected]>; David S. Miller <[email protected]>
> Subject: [Intel-wired-lan] [PATCH] ixgbe: Fix module_param
> allow_unsupported_sfp type
>
> The module_param allow_unsupported_sfp should be a boolean to match
> the type in the ixgbe_hw struct.
>
> Signed-off-by: Jeff Daly <[email protected]>
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>

Tested-by: Gurucharan <[email protected]> (A Contingent worker at Intel)