2022-04-15 06:45:57

by Davidlohr Bueso

[permalink] [raw]
Subject: Re: [PATCH v3 3/4] hugetlb: Fix return value of __setup handlers

On Wed, 13 Apr 2022, Peng Liu wrote:

>When __setup() return '0', using invalid option values causes the
>entire kernel boot option string to be reported as Unknown. Hugetlb
>calls __setup() and will return '0' when set invalid parameter
>string.
>
>The following phenomenon is observed:
> cmdline:
> hugepagesz=1Y hugepages=1
> dmesg:
> HugeTLB: unsupported hugepagesz=1Y
> HugeTLB: hugepages=1 does not follow a valid hugepagesz, ignoring
> Unknown kernel command line parameters "hugepagesz=1Y hugepages=1"
>
>Since hugetlb will print warning/error information before return for
>invalid parameter string, just use return '1' to avoid print again.
>
>Signed-off-by: Peng Liu <[email protected]>
>Reviewed-by: Baolin Wang <[email protected]>
>Reviewed-by: Muchun Song <[email protected]>
>Reviewed-by: Mike Kravetz <[email protected]>

Reviewed-by: Davidlohr Bueso <[email protected]>