2022-04-16 02:05:28

by Peng Fan (OSS)

Subject: [PATCH V4] remoteproc: imx_rproc: Ignore create mem entry for resource table

From: Peng Fan <[email protected]>

Resource table is used by Linux to get information published by
remote processor. It should be not be used for memory allocation, so
not create rproc mem entry.

Fixes: b29b4249f8f0 ("remoteproc: imx_rproc: add i.MX specific parse fw hook")
Signed-off-by: Peng Fan <[email protected]>
---

V4:
Typo fix
use strcmp, not strncmp

V3:
Update commit log
Update Fixes tag

V2:
Add Fixes tag
Separate the patch from https://patchwork.kernel.org/project/linux-remoteproc/patch/[email protected]/
Address typo


drivers/remoteproc/imx_rproc.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
index 7a096f1891e6..91eb037089ef 100644
--- a/drivers/remoteproc/imx_rproc.c
+++ b/drivers/remoteproc/imx_rproc.c
@@ -423,6 +423,9 @@ static int imx_rproc_prepare(struct rproc *rproc)
if (!strcmp(it.node->name, "vdev0buffer"))
continue;

+ if (!strcmp(it.node->name, "rsc-table"))
+ continue;
+
rmem = of_reserved_mem_lookup(it.node);
if (!rmem) {
dev_err(priv->dev, "unable to acquire memory-region\n");
--
2.25.1

2022-04-19 03:52:12

by Mathieu Poirier

Subject: Re: [PATCH V4] remoteproc: imx_rproc: Ignore create mem entry for resource table

On Fri, Apr 15, 2022 at 10:57:37AM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <[email protected]>
>
> Resource table is used by Linux to get information published by
> remote processor. It should be not be used for memory allocation, so
> not create rproc mem entry.
>
> Fixes: b29b4249f8f0 ("remoteproc: imx_rproc: add i.MX specific parse fw hook")
> Signed-off-by: Peng Fan <[email protected]>
> ---
>
> V4:
> Typo fix
> use strcmp, not strncmp
>
> V3:
> Update commit log
> Update Fixes tag
>
> V2:
> Add Fixes tag
> Separate the patch from https://patchwork.kernel.org/project/linux-remoteproc/patch/[email protected]/
> Address typo
>
>
> drivers/remoteproc/imx_rproc.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
> index 7a096f1891e6..91eb037089ef 100644
> --- a/drivers/remoteproc/imx_rproc.c
> +++ b/drivers/remoteproc/imx_rproc.c
> @@ -423,6 +423,9 @@ static int imx_rproc_prepare(struct rproc *rproc)
> if (!strcmp(it.node->name, "vdev0buffer"))
> continue;
>
> + if (!strcmp(it.node->name, "rsc-table"))
> + continue;
> +

Applied.

Thanks,
Mathieu

> rmem = of_reserved_mem_lookup(it.node);
> if (!rmem) {
> dev_err(priv->dev, "unable to acquire memory-region\n");
> --
> 2.25.1
>