2022-04-16 19:38:59

by Ze Zhang

Subject: [PATCH 2/2] selftests/ftrace: add mips support for kprobe args syntax tests

This is the mips variant of commit <3990b5baf225> ("selftests/ftrace:
Add s390 support for kprobe args tests").

Signed-off-by: Ze Zhang <[email protected]>
---
.../selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc
index 47d84b5cb6ca..d4662c8cf407 100644
--- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc
+++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc
@@ -36,6 +36,10 @@ s390*)
GOODREG=%r2
BADREG=%s2
;;
+mips*)
+ GOODREG=%r4
+ BADREG=%r12
+;;
*)
echo "Please implement other architecture here"
exit_untested
--
2.20.1

2022-04-19 00:44:15

by Steven Rostedt

Subject: Re: [PATCH 2/2] selftests/ftrace: add mips support for kprobe args syntax tests

On Sat, 16 Apr 2022 19:48:48 +0800
Ze Zhang <[email protected]> wrote:

> This is the mips variant of commit <3990b5baf225> ("selftests/ftrace:
> Add s390 support for kprobe args tests").
>
> Signed-off-by: Ze Zhang <[email protected]>
> ---
> .../selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc
> index 47d84b5cb6ca..d4662c8cf407 100644
> --- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc
> +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc
> @@ -36,6 +36,10 @@ s390*)
> GOODREG=%r2
> BADREG=%s2
> ;;
> +mips*)
> + GOODREG=%r4
> + BADREG=%r12
> +;;
> *)
> echo "Please implement other architecture here"
> exit_untested

This needs an Ack from Masami as well.

Acked-by: Steven Rostedt (Google) <[email protected]>

-- Steve

2022-04-19 20:54:12

by Masami Hiramatsu

Subject: Re: [PATCH 2/2] selftests/ftrace: add mips support for kprobe args syntax tests

On Mon, 18 Apr 2022 13:30:45 -0400
Steven Rostedt <[email protected]> wrote:

> On Sat, 16 Apr 2022 19:48:48 +0800
> Ze Zhang <[email protected]> wrote:
>
> > This is the mips variant of commit <3990b5baf225> ("selftests/ftrace:
> > Add s390 support for kprobe args tests").

Great!

Acked-by: Masami Hiramatsu <[email protected]>

Thanks!

> >
> > Signed-off-by: Ze Zhang <[email protected]>
> > ---
> > .../selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc
> > index 47d84b5cb6ca..d4662c8cf407 100644
> > --- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc
> > +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc
> > @@ -36,6 +36,10 @@ s390*)
> > GOODREG=%r2
> > BADREG=%s2
> > ;;
> > +mips*)
> > + GOODREG=%r4
> > + BADREG=%r12
> > +;;
> > *)
> > echo "Please implement other architecture here"
> > exit_untested
>
> This needs an Ack from Masami as well.
>
> Acked-by: Steven Rostedt (Google) <[email protected]>
>
> -- Steve


--
Masami Hiramatsu <[email protected]>