2022-04-18 03:59:29

by Li Qiong

Subject: [PATCH] arch/x86: use 'NULL' insteadof '0' as null pointer

Sparse warns: "Using plain integer as NULL pointer".
Use 'NULL' as null pointer.

Signed-off-by: liqiong <[email protected]>
---
arch/x86/events/rapl.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/x86/events/rapl.c b/arch/x86/events/rapl.c
index 77e3a47af5ad..7d70690fded5 100644
--- a/arch/x86/events/rapl.c
+++ b/arch/x86/events/rapl.c
@@ -537,11 +537,11 @@ static struct perf_msr intel_rapl_spr_msrs[] = {
* - want to use same event codes across both architectures
*/
static struct perf_msr amd_rapl_msrs[] = {
- [PERF_RAPL_PP0] = { 0, &rapl_events_cores_group, 0, false, 0 },
+ [PERF_RAPL_PP0] = { 0, &rapl_events_cores_group, NULL, false, 0 },
[PERF_RAPL_PKG] = { MSR_AMD_PKG_ENERGY_STATUS, &rapl_events_pkg_group, test_msr, false, RAPL_MSR_MASK },
- [PERF_RAPL_RAM] = { 0, &rapl_events_ram_group, 0, false, 0 },
- [PERF_RAPL_PP1] = { 0, &rapl_events_gpu_group, 0, false, 0 },
- [PERF_RAPL_PSYS] = { 0, &rapl_events_psys_group, 0, false, 0 },
+ [PERF_RAPL_RAM] = { 0, &rapl_events_ram_group, NULL, false, 0 },
+ [PERF_RAPL_PP1] = { 0, &rapl_events_gpu_group, NULL, false, 0 },
+ [PERF_RAPL_PSYS] = { 0, &rapl_events_psys_group, NULL, false, 0 },
};

static int rapl_cpu_offline(unsigned int cpu)
--
2.25.1

2022-04-19 12:08:39

by Li Qiong

Subject: Re: [PATCH] arch/x86: use 'NULL' insteadof '0' as null pointer

在 2022年04月19日 15:37, Peter Zijlstra 写道:
> On Sun, Apr 17, 2022 at 11:41:48PM +0800, liqiong wrote:
>> Sparse warns: "Using plain integer as NULL pointer".
> What's wrong with that?

Just a sparse warning.

2022-04-19 13:26:53

by Peter Zijlstra

Subject: Re: [PATCH] arch/x86: use 'NULL' insteadof '0' as null pointer

On Sun, Apr 17, 2022 at 11:41:48PM +0800, liqiong wrote:
> Sparse warns: "Using plain integer as NULL pointer".

What's wrong with that?