2022-04-18 08:53:33

by Kuldeep Singh

[permalink] [raw]
Subject: [PATCH v3 3/6] arm64: dts: qcom: msm8996: User generic node name for DMA

Qcom BAM DT spec expects generic DMA controller node name as
"dma-controller" to enable validations.

Signed-off-by: Kuldeep Singh <[email protected]>
Reviewed-by: Krzysztof Kozlowski <[email protected]>
---
v3: Add Krzysztof R-b tag
---
v2: No change
---
arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index b9a48cfd760f..c4cfab92a44e 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -707,7 +707,7 @@ tsens1: thermal-sensor@4ad000 {
#thermal-sensor-cells = <1>;
};

- cryptobam: dma@644000 {
+ cryptobam: dma-controller@644000 {
compatible = "qcom,bam-v1.7.0";
reg = <0x00644000 0x24000>;
interrupts = <GIC_SPI 206 IRQ_TYPE_LEVEL_HIGH>;
--
2.25.1


2022-04-18 12:38:01

by Bhupesh Sharma

[permalink] [raw]
Subject: Re: [PATCH v3 3/6] arm64: dts: qcom: msm8996: User generic node name for DMA

Hi Kuldeep,

On Mon, 18 Apr 2022 at 02:34, Kuldeep Singh <[email protected]> wrote:
>
> Qcom BAM DT spec expects generic DMA controller node name as
> "dma-controller" to enable validations.

This is already fixed with in-flight patch
<https://lore.kernel.org/lkml/[email protected]/T/#mb84230b9b8e06544859ccf5e16a7651fac79c933>

Thanks,
Bhupesh

> Signed-off-by: Kuldeep Singh <[email protected]>
> Reviewed-by: Krzysztof Kozlowski <[email protected]>
> ---
> v3: Add Krzysztof R-b tag
> ---
> v2: No change
> ---
> arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index b9a48cfd760f..c4cfab92a44e 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -707,7 +707,7 @@ tsens1: thermal-sensor@4ad000 {
> #thermal-sensor-cells = <1>;
> };
>
> - cryptobam: dma@644000 {
> + cryptobam: dma-controller@644000 {
> compatible = "qcom,bam-v1.7.0";
> reg = <0x00644000 0x24000>;
> interrupts = <GIC_SPI 206 IRQ_TYPE_LEVEL_HIGH>;
> --
> 2.25.1
>

2022-04-19 04:49:40

by Kuldeep Singh

[permalink] [raw]
Subject: Re: [PATCH v3 3/6] arm64: dts: qcom: msm8996: User generic node name for DMA

On Mon, Apr 18, 2022 at 11:02:11AM +0530, Bhupesh Sharma wrote:
> This is already fixed with in-flight patch
> <https://lore.kernel.org/lkml/[email protected]/T/#mb84230b9b8e06544859ccf5e16a7651fac79c933>

Your change is currently not accepted/merged and don't think it's in
maintainer's queue as well. So, probably it's not in-flight patch as of
now.

2022-04-21 06:42:04

by Kuldeep Singh

[permalink] [raw]
Subject: Re: [PATCH v3 3/6] arm64: dts: qcom: msm8996: User generic node name for DMA

On Tue, Apr 19, 2022 at 02:37:19AM +0530, Bhupesh Sharma wrote:
> My patch already has an ACK from the DMA maintainer, whereas your's is
> still in review.

Sincere apologies, I saw your original patch only and missed Ack.
Please note, mine change is reviewed by FDT maintainer.

> So please drop this patch from the next version.

If we are going to have mine binding version, then skipping dts change
here will trigger Rob's bot warning.