* Move define statements to the top of the file
* Add ram and eeprom start addr as define statements
* fix masking of bits using GENMASK macro from bits.h
Moses Christopher Bollavarapu (3):
media: i2c: video-i2c: Move defines to the top of the file
media: i2c: video-i2c: Replace constants with proper names
media: i2c: video-i2c: Use GENMASK for masking bits
drivers/media/i2c/video-i2c.c | 61 +++++++++++++++++++----------------
1 file changed, 34 insertions(+), 27 deletions(-)
--
2.30.2
Replace 0x0380 with GENMASK(9, 7) to obtain 0b0000_0011_1000_0000
Signed-off-by: Moses Christopher Bollavarapu <[email protected]>
---
drivers/media/i2c/video-i2c.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/video-i2c.c b/drivers/media/i2c/video-i2c.c
index 1d5f48329cb2..e08e3579c0a1 100644
--- a/drivers/media/i2c/video-i2c.c
+++ b/drivers/media/i2c/video-i2c.c
@@ -9,6 +9,7 @@
* - Melexis MLX90640 Thermal Cameras
*/
+#include <linux/bits.h>
#include <linux/delay.h>
#include <linux/freezer.h>
#include <linux/hwmon.h>
@@ -62,7 +63,7 @@
/* Control register */
#define MLX90640_REG_CTL1 0x800d
-#define MLX90640_REG_CTL1_MASK 0x0380
+#define MLX90640_REG_CTL1_MASK GENMASK(9, 7)
#define MLX90640_REG_CTL1_MASK_SHIFT 7
struct video_i2c_chip;
--
2.30.2