2022-04-21 21:45:36

by Kees Cook

[permalink] [raw]
Subject: Re: [RFC PATCH 11/11] driver/int3400_thermal: Fix prototype matching

On Wed, Apr 20, 2022 at 04:12:26PM -0700, Joao Moreira wrote:
> >
> > Ah-ha, thanks. I think this will fix it, but I haven't tested it:
>
> I tried that, and IIRC, there was an error or warning in the assignment that
> happens a bit further in the file. My bad for not having it all properly
> tracked.

This builds for me without warnings, but maybe there is some weird
config I'm missing.

--
Kees Cook


2022-04-22 18:41:34

by Joao Moreira

[permalink] [raw]
Subject: Re: [RFC PATCH 11/11] driver/int3400_thermal: Fix prototype matching

On 2022-04-20 16:25, Kees Cook wrote:
> On Wed, Apr 20, 2022 at 04:12:26PM -0700, Joao Moreira wrote:
>> >
>> > Ah-ha, thanks. I think this will fix it, but I haven't tested it:
>>
>> I tried that, and IIRC, there was an error or warning in the
>> assignment that
>> happens a bit further in the file. My bad for not having it all
>> properly
>> tracked.
>
> This builds for me without warnings, but maybe there is some weird
> config I'm missing.

Nah, I was just confused. This works fine and fixes the violation
(confirmed after compiling and booting it).