Hi all,
After merging the block tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
fs/io_uring.c: In function '__io_sqe_files_unregister':
fs/io_uring.c:8992:13: warning: unused variable 'i' [-Wunused-variable]
8992 | int i;
| ^
Introduced by commit
16b217ed7bb3 ("io_uring: store SCM state in io_fixed_file->file_ptr")
--
Cheers,
Stephen Rothwell
On 4/20/22 8:02 PM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the block tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> fs/io_uring.c: In function '__io_sqe_files_unregister':
> fs/io_uring.c:8992:13: warning: unused variable 'i' [-Wunused-variable]
> 8992 | int i;
> | ^
>
> Introduced by commit
>
> 16b217ed7bb3 ("io_uring: store SCM state in io_fixed_file->file_ptr")
Thanks, looks like I forgot to amend. Will fix it up.
--
Jens Axboe
Hi all,
On Thu, 21 Apr 2022 12:02:03 +1000 Stephen Rothwell <[email protected]> wrote:
>
> After merging the block tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> fs/io_uring.c: In function '__io_sqe_files_unregister':
> fs/io_uring.c:8992:13: warning: unused variable 'i' [-Wunused-variable]
> 8992 | int i;
> | ^
>
> Introduced by commit
>
> 16b217ed7bb3 ("io_uring: store SCM state in io_fixed_file->file_ptr")
This become a build failure for i386 defconfig, so I added the
following patch.
From: Stephen Rothwell <[email protected]>
Date: Thu, 21 Apr 2022 15:34:32 +1000
Subject: [PATCH] fix up for "io_uring: store SCM state in
io_fixed_file->file_ptr"
Signed-off-by: Stephen Rothwell <[email protected]>
---
fs/io_uring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/io_uring.c b/fs/io_uring.c
index 1f6004ba0463..9ace35873810 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -8989,9 +8989,9 @@ static void io_free_file_tables(struct io_file_table *table)
static void __io_sqe_files_unregister(struct io_ring_ctx *ctx)
{
+#if !defined(IO_URING_SCM_ALL)
int i;
-#if !defined(IO_URING_SCM_ALL)
for (i = 0; i < ctx->nr_user_files; i++) {
struct file *file = io_file_from_index(ctx, i);
--
2.35.1
--
Cheers,
Stephen Rothwell