2022-04-20 20:57:10

by Peter Zijlstra

Subject: [PATCH 0/2] objtool: Fix code reloc vs weak symbols

Two fun bugs that make can cause other fun fail if you have a fresh enough
toolchain that strips unused section symbols.

The symptoms can vary between a faulty unwind to a kernel splat for trying to
patch the wrong text.

I found it while playing with text patching and Josh confirmed it very much
affects ORC data too.

2022-04-22 21:15:28

by Josh Poimboeuf

Subject: Re: [PATCH 0/2] objtool: Fix code reloc vs weak symbols

On Tue, Apr 19, 2022 at 10:32:54PM +0200, Peter Zijlstra wrote:
> Two fun bugs that make can cause other fun fail if you have a fresh enough
> toolchain that strips unused section symbols.
>
> The symptoms can vary between a faulty unwind to a kernel splat for trying to
> patch the wrong text.
>
> I found it while playing with text patching and Josh confirmed it very much
> affects ORC data too.

Seems to work ok with testing.

With the XXX comment removed or fixed:

Acked-by: Josh Poimboeuf <[email protected]>

--
Josh