2022-04-22 17:23:59

by Herve Codina

Subject: [PATCH v3 7/8] ARM: dts: r9a06g032: Add USB PHY DT support

Define the r9a06g032 generic part of the USB PHY device node.

Signed-off-by: Herve Codina <[email protected]>
---
arch/arm/boot/dts/r9a06g032.dtsi | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/arch/arm/boot/dts/r9a06g032.dtsi b/arch/arm/boot/dts/r9a06g032.dtsi
index 33581f0c55c4..58af07eb75c9 100644
--- a/arch/arm/boot/dts/r9a06g032.dtsi
+++ b/arch/arm/boot/dts/r9a06g032.dtsi
@@ -59,6 +59,12 @@ ext_rtc_clk: extrtcclk {
clock-frequency = <0>;
};

+ usbphy: usbphy {
+ #phy-cells = <0>;
+ compatible = "usb-nop-xceiv";
+ status = "disabled";
+ };
+
soc {
compatible = "simple-bus";
#address-cells = <1>;
--
2.35.1

2022-04-23 11:02:17

by Sergey Shtylyov

Subject: Re: [PATCH v3 7/8] ARM: dts: r9a06g032: Add USB PHY DT support

Hello!

On 4/22/22 3:08 PM, Herve Codina wrote:

> Define the r9a06g032 generic part of the USB PHY device node.
>
> Signed-off-by: Herve Codina <[email protected]>
> ---
> arch/arm/boot/dts/r9a06g032.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r9a06g032.dtsi b/arch/arm/boot/dts/r9a06g032.dtsi
> index 33581f0c55c4..58af07eb75c9 100644
> --- a/arch/arm/boot/dts/r9a06g032.dtsi
> +++ b/arch/arm/boot/dts/r9a06g032.dtsi
> @@ -59,6 +59,12 @@ ext_rtc_clk: extrtcclk {
> clock-frequency = <0>;
> };
>
> + usbphy: usbphy {

I think the node name should be "usb-phy"...

[...]

MBR, Sergey

2022-04-24 15:36:05

by Sergey Shtylyov

Subject: Re: [PATCH v3 7/8] ARM: dts: r9a06g032: Add USB PHY DT support

On 4/23/22 12:09 PM, Sergey Shtylyov wrote:

[...]
>> Define the r9a06g032 generic part of the USB PHY device node.
>>
>> Signed-off-by: Herve Codina <[email protected]>
>> ---
>> arch/arm/boot/dts/r9a06g032.dtsi | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/r9a06g032.dtsi b/arch/arm/boot/dts/r9a06g032.dtsi
>> index 33581f0c55c4..58af07eb75c9 100644
>> --- a/arch/arm/boot/dts/r9a06g032.dtsi
>> +++ b/arch/arm/boot/dts/r9a06g032.dtsi
>> @@ -59,6 +59,12 @@ ext_rtc_clk: extrtcclk {
>> clock-frequency = <0>;
>> };
>>
>> + usbphy: usbphy {
>
> I think the node name should be "usb-phy"...

It's not my thinking alone, the DT spec documents "usb-phy" in section 2.2.2. :-)

> [...]

MBR, Sergey

2022-04-28 12:18:34

by Geert Uytterhoeven

Subject: Re: [PATCH v3 7/8] ARM: dts: r9a06g032: Add USB PHY DT support

Hi Hervé,

On Fri, Apr 22, 2022 at 2:09 PM Herve Codina <[email protected]> wrote:
> Define the r9a06g032 generic part of the USB PHY device node.
>
> Signed-off-by: Herve Codina <[email protected]>

Thanks for your patch!

> --- a/arch/arm/boot/dts/r9a06g032.dtsi
> +++ b/arch/arm/boot/dts/r9a06g032.dtsi
> @@ -59,6 +59,12 @@ ext_rtc_clk: extrtcclk {
> clock-frequency = <0>;
> };
>
> + usbphy: usbphy {

Please preserve sort order (by node name).

> + #phy-cells = <0>;
> + compatible = "usb-nop-xceiv";
> + status = "disabled";
> + };
> +
> soc {
> compatible = "simple-bus";
> #address-cells = <1>;

The rest LGTM, so with the above fixed:
Reviewed-by: Geert Uytterhoeven <[email protected]>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2022-04-28 13:53:58

by Herve Codina

Subject: Re: [PATCH v3 7/8] ARM: dts: r9a06g032: Add USB PHY DT support

Hi Geert,
On Thu, 28 Apr 2022 11:51:44 +0200
Geert Uytterhoeven <[email protected]> wrote:

> Hi Hervé,
>
> On Fri, Apr 22, 2022 at 2:09 PM Herve Codina <[email protected]> wrote:
> > Define the r9a06g032 generic part of the USB PHY device node.
> >
> > Signed-off-by: Herve Codina <[email protected]>
>
> Thanks for your patch!
>
> > --- a/arch/arm/boot/dts/r9a06g032.dtsi
> > +++ b/arch/arm/boot/dts/r9a06g032.dtsi
> > @@ -59,6 +59,12 @@ ext_rtc_clk: extrtcclk {
> > clock-frequency = <0>;
> > };
> >
> > + usbphy: usbphy {
>
> Please preserve sort order (by node name).

Ok, will be done.

>
> > + #phy-cells = <0>;
> > + compatible = "usb-nop-xceiv";
> > + status = "disabled";
> > + };
> > +
> > soc {
> > compatible = "simple-bus";
> > #address-cells = <1>;
>
> The rest LGTM, so with the above fixed:
> Reviewed-by: Geert Uytterhoeven <[email protected]>
>

Regards,
Hervé

--
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

2022-04-29 15:38:08

by Herve Codina

Subject: Re: [PATCH v3 7/8] ARM: dts: r9a06g032: Add USB PHY DT support

Hi Sergey,

On Sat, 23 Apr 2022 19:41:09 +0300
Sergey Shtylyov <[email protected]> wrote:

> On 4/23/22 12:09 PM, Sergey Shtylyov wrote:
>
> [...]
> >> Define the r9a06g032 generic part of the USB PHY device node.
> >>
> >> Signed-off-by: Herve Codina <[email protected]>
> >> ---
> >> arch/arm/boot/dts/r9a06g032.dtsi | 6 ++++++
> >> 1 file changed, 6 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/r9a06g032.dtsi b/arch/arm/boot/dts/r9a06g032.dtsi
> >> index 33581f0c55c4..58af07eb75c9 100644
> >> --- a/arch/arm/boot/dts/r9a06g032.dtsi
> >> +++ b/arch/arm/boot/dts/r9a06g032.dtsi
> >> @@ -59,6 +59,12 @@ ext_rtc_clk: extrtcclk {
> >> clock-frequency = <0>;
> >> };
> >>
> >> + usbphy: usbphy {
> >
> > I think the node name should be "usb-phy"...
>
> It's not my thinking alone, the DT spec documents "usb-phy" in section 2.2.2. :-)

Will be changed in v4.

Thanks for pointing this.

Regards,
Hervé

--
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com